Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ExceptionStatePlaceholder.h

Issue 2614013003: Remove IgnorableExceptionState (Closed)
Patch Set: temp Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ExceptionStatePlaceholder.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/ExceptionStatePlaceholder.h b/third_party/WebKit/Source/bindings/core/v8/ExceptionStatePlaceholder.h
index 8594909a03b50442f463c1a6f0b4be17fb746972..83c10d7959ea43fabc712872c3f9d8bf8ffc8c23 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ExceptionStatePlaceholder.h
+++ b/third_party/WebKit/Source/bindings/core/v8/ExceptionStatePlaceholder.h
@@ -38,27 +38,7 @@
namespace blink {
-class IgnorableExceptionState final : public ExceptionState {
- WTF_MAKE_NONCOPYABLE(IgnorableExceptionState);
-
- public:
- IgnorableExceptionState()
- : ExceptionState(nullptr,
- ExceptionState::UnknownContext,
- nullptr,
- nullptr) {}
-
- ExceptionState& returnThis() { return *this; }
-
- void throwDOMException(ExceptionCode, const String& message) override {}
- void throwRangeError(const String& message) override{};
- void throwSecurityError(const String& sanitizedMessage,
- const String& unsanitizedMessage) override {}
- void throwTypeError(const String& message) override {}
- void rethrowV8Exception(v8::Local<v8::Value>) override{};
-};
-
-#define IGNORE_EXCEPTION (::blink::IgnorableExceptionState().returnThis())
+#define IGNORE_EXCEPTION (::blink::DummyExceptionStateForTesting().returnThis())
haraken 2017/01/06 00:52:53 I noticed that we should try to remove IGNORE_EXCE
#if ENABLE(ASSERT)
@@ -88,7 +68,8 @@ class CORE_EXPORT NoExceptionStateAssertionChecker final
#else
-#define ASSERT_NO_EXCEPTION (::blink::IgnorableExceptionState().returnThis())
+#define ASSERT_NO_EXCEPTION \
+ (::blink::DummyExceptionStateForTesting().returnThis())
#endif

Powered by Google App Engine
This is Rietveld 408576698