Remove IgnorableExceptionState

third_party/WebKit/Source/bindings/core/v8/ExceptionStatePlaceholder.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 20 matching lines @@
 #ifndef ExceptionStatePlaceholder_h
 #define ExceptionStatePlaceholder_h
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "core/CoreExport.h"
 #include "wtf/Assertions.h"
 #include "wtf/text/WTFString.h"
 
 namespace blink {
 
-class IgnorableExceptionState final : public ExceptionState {
-  WTF_MAKE_NONCOPYABLE(IgnorableExceptionState);
-
- public:
-  IgnorableExceptionState()
-      : ExceptionState(nullptr,
-                       ExceptionState::UnknownContext,
-                       nullptr,
-                       nullptr) {}
-
-  ExceptionState& returnThis() { return *this; }
-
-  void throwDOMException(ExceptionCode, const String& message) override {}
-  void throwRangeError(const String& message) override{};
-  void throwSecurityError(const String& sanitizedMessage,
-                          const String& unsanitizedMessage) override {}
-  void throwTypeError(const String& message) override {}
-  void rethrowV8Exception(v8::Local<v8::Value>) override{};
-};
-
-#define IGNORE_EXCEPTION (::blink::IgnorableExceptionState().returnThis())
+#define IGNORE_EXCEPTION (::blink::DummyExceptionStateForTesting().returnThis())

[haraken, 2017/01/06 00:52:53]

I noticed that we should try to remove IGNORE_EXCEPTION as well... At a first
glance, there're a lot of IGNORE_EXCEPTIONs that should be replaced with normal
(non-ignorable) exception states.

 
 #if ENABLE(ASSERT)
 
 class CORE_EXPORT NoExceptionStateAssertionChecker final

[haraken, 2017/01/06 00:52:53]

I'll replace this with NonThroableExceptionState in a follow-up CL.

Then remove this file entirely.

     : public ExceptionState {
   WTF_MAKE_NONCOPYABLE(NoExceptionStateAssertionChecker);
 
  public:
   NoExceptionStateAssertionChecker(const char* file, int line);
 
   ExceptionState& returnThis() { return *this; }
 
   void throwDOMException(ExceptionCode, const String& message) override;
   void throwRangeError(const String& message) override;
   void throwSecurityError(const String& sanitizedMessage,
                           const String& unsanitizedMessage) override;
   void throwTypeError(const String& message) override;
   void rethrowV8Exception(v8::Local<v8::Value>) override;
 
  private:
   const char* m_file;
   const int m_line;
 };
 
 #define ASSERT_NO_EXCEPTION \
   (::blink::NoExceptionStateAssertionChecker(__FILE__, __LINE__).returnThis())
 
 #else
 
-#define ASSERT_NO_EXCEPTION (::blink::IgnorableExceptionState().returnThis())
+#define ASSERT_NO_EXCEPTION \
+  (::blink::DummyExceptionStateForTesting().returnThis())
 
 #endif
 
 }  // namespace blink
 
 #endif  // ExceptionStatePlaceholder_h