Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2613903003: Reland of "Mustash: Ensure surfaces submitted to Mus by WM and embedders contain Surfaces with embe… (Closed)

Created:
3 years, 11 months ago by sadrul
Modified:
3 years, 11 months ago
Reviewers:
sky, jbauman
CC:
chromium-reviews, rjkroege, kalyank, sadrul, mfomitchev
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of "Mustash: Ensure surfaces submitted to Mus by WM and embedders contain Surfaces with embeded content." - Use SurfaceLayers in embedders and Window Manager to properly position the embedded content in the layer tree. - WM no longer uses underlay surfaces for window decorations. Instead they are submitted to Mus as part of the WM's surface. - FrameGenerator now only creates SurfaceDrawQuad for the top-level window rather than recursively creating SurfaceDrawQuad for all windows in the window tree, since all surfaces are now part of the tree rooted at the surface of the top-level window. Previously landed in crrev.com/441492, but reverted in crrev.com/441522 since it broke some tests on Windows. This CL includes a fix for that brokenness. BUG=672943, 669964 TBR=jbauman@ for DEPS change (previously lgtm'ed in the original CL) Review-Url: https://codereview.chromium.org/2613903003 Cr-Commit-Position: refs/heads/master@{#441753} Committed: https://chromium.googlesource.com/chromium/src/+/2397b79688fd6542405db49e80585ae53bfd4d92

Patch Set 1 : original CL #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+225 lines, -114 lines) Patch
M services/ui/ws/display.h View 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/ws/display.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M services/ui/ws/frame_generator.h View 1 chunk +3 lines, -6 lines 0 comments Download
M services/ui/ws/frame_generator.cc View 1 2 chunks +23 lines, -63 lines 0 comments Download
M services/ui/ws/frame_generator_delegate.h View 1 chunk +2 lines, -0 lines 0 comments Download
M services/ui/ws/frame_generator_unittest.cc View 3 chunks +12 lines, -40 lines 0 comments Download
M services/ui/ws/platform_display_default.h View 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/ws/platform_display_default.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M services/ui/ws/platform_display_delegate.h View 1 chunk +3 lines, -0 lines 0 comments Download
M services/ui/ws/server_window_compositor_frame_sink_manager.h View 1 chunk +2 lines, -0 lines 0 comments Download
M services/ui/ws/server_window_compositor_frame_sink_manager.cc View 1 chunk +1 line, -3 lines 0 comments Download
M services/ui/ws/test_utils.h View 1 chunk +4 lines, -1 line 0 comments Download
M services/ui/ws/test_utils.cc View 1 chunk +7 lines, -1 line 0 comments Download
M ui/aura/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/aura/mus/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A ui/aura/mus/client_surface_embedder.h View 1 chunk +45 lines, -0 lines 0 comments Download
A ui/aura/mus/client_surface_embedder.cc View 1 chunk +90 lines, -0 lines 0 comments Download
M ui/aura/mus/window_port_mus.h View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/aura/mus/window_port_mus.cc View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
sadrul
This is a reland of https://crrev.com/441492 Patchset#1 is the original CL, patchset#2 has the fix ...
3 years, 11 months ago (2017-01-05 19:50:29 UTC) #5
sky
LGTM
3 years, 11 months ago (2017-01-05 20:02:47 UTC) #7
sadrul
TBR'ing jbauman@ since DEPS already approved in the original CL
3 years, 11 months ago (2017-01-05 21:11:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2613903003/40001
3 years, 11 months ago (2017-01-05 21:11:46 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 21:18:28 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/2397b79688fd6542405db49e8058...

Powered by Google App Engine
This is Rietveld 408576698