DevTools: migrate from external Maps to symbols in the bindings objects.

DevTools: migrate from external Maps to symbols in the bindings objects.

BUG=

Committed: https://crrev.com/03d450accc6d363d4cf00835d63fc112e06afdf1
Cr-Commit-Position: refs/heads/master@{#441414}

[pfeldman, 2017-01-03 23:41:17]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2017-01-04 01:04:08]

https://codereview.chromium.org/2613643002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js
(right):

https://codereview.chromium.org/2613643002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js:478:
this._sourceMapping = this._backupMappings.pop();
this._backupMappings could be undefined

https://codereview.chromium.org/2613643002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js
(right):

https://codereview.chromium.org/2613643002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:62:
this._decorations = null;
Do "Multimap|undefined" and don't assign here.

https://codereview.chromium.org/2613643002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:64:
this._history = [];
ditto

https://codereview.chromium.org/2613643002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:66:
this._messages = null;
ditto

[pfeldman, 2017-01-04 01:13:48]

https://codereview.chromium.org/2613643002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js
(right):

https://codereview.chromium.org/2613643002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js:478:
this._sourceMapping = this._backupMappings.pop();
On 2017/01/04 01:04:08, dgozman wrote:
> this._backupMappings could be undefined

Done.

https://codereview.chromium.org/2613643002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js
(right):

https://codereview.chromium.org/2613643002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:62:
this._decorations = null;
On 2017/01/04 01:04:08, dgozman wrote:
> Do "Multimap|undefined" and don't assign here.

should be = null;

https://codereview.chromium.org/2613643002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:64:
this._history = [];
On 2017/01/04 01:04:08, dgozman wrote:
> ditto

Acknowledged.

https://codereview.chromium.org/2613643002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:66:
this._messages = null;
On 2017/01/04 01:04:08, dgozman wrote:
> ditto

Acknowledged.

[pfeldman, 2017-01-04 01:13:57]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 01:14:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 02:38:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 02:38:54]

Dry run: This issue passed the CQ dry run.

[dgozman, 2017-01-04 17:46:43]

lgtm

[pfeldman, 2017-01-04 18:29:41]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2017-01-04 18:30:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 18:35:10]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483554581349980,
"parent_rev": "a96081b9d41458a682d72bb9f010a8698a969aa5", "commit_rev":
"09150e95e25d3cd48c5ef681112ceddbe611bd85"}

[commit-bot: I haz the power, 2017-01-04 18:35:43]

Description was changed from

==========
DevTools: migrate from external Maps to symbols in the bindings objects.

BUG=
==========

to

==========
DevTools: migrate from external Maps to symbols in the bindings objects.

BUG=

Review-Url: https://codereview.chromium.org/2613643002
==========

[commit-bot: I haz the power, 2017-01-04 18:35:44]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2017-01-04 18:38:38]

Description was changed from

==========
DevTools: migrate from external Maps to symbols in the bindings objects.

BUG=

Review-Url: https://codereview.chromium.org/2613643002
==========

to

==========
DevTools: migrate from external Maps to symbols in the bindings objects.

BUG=

Committed: https://crrev.com/03d450accc6d363d4cf00835d63fc112e06afdf1
Cr-Commit-Position: refs/heads/master@{#441414}
==========

[commit-bot: I haz the power, 2017-01-04 18:38:39]

Patchset 2 (id:??) landed as
https://crrev.com/03d450accc6d363d4cf00835d63fc112e06afdf1
Cr-Commit-Position: refs/heads/master@{#441414}