Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/RevisionHistoryView.js

Issue 2613643002: DevTools: migrate from external Maps to symbols in the bindings objects. (Closed)
Patch Set: review comments addressed. Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sources/RevisionHistoryView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sources/RevisionHistoryView.js b/third_party/WebKit/Source/devtools/front_end/sources/RevisionHistoryView.js
index 8c843504ca36f4ad3dfafc1335ee2597c2a74b24..c00246955843eca8ada12dae49d05b3d96574702 100644
--- a/third_party/WebKit/Source/devtools/front_end/sources/RevisionHistoryView.js
+++ b/third_party/WebKit/Source/devtools/front_end/sources/RevisionHistoryView.js
@@ -46,7 +46,7 @@ Sources.RevisionHistoryView = class extends UI.VBox {
* @this {Sources.RevisionHistoryView}
*/
function populateRevisions(uiSourceCode) {
- if (uiSourceCode.history.length)
+ if (uiSourceCode.history().length)
this._createUISourceCodeItem(uiSourceCode);
}
@@ -88,11 +88,11 @@ Sources.RevisionHistoryView = class extends UI.VBox {
this._uiSourceCodeItems.set(uiSourceCode, uiSourceCodeItem);
- var revisionCount = uiSourceCode.history.length;
+ var history = uiSourceCode.history();
+ var revisionCount = history.length;
for (var i = revisionCount - 1; i >= 0; --i) {
- var revision = uiSourceCode.history[i];
- var historyItem =
- new Sources.RevisionHistoryTreeElement(revision, uiSourceCode.history[i - 1], i !== revisionCount - 1);
+ var revision = history[i];
+ var historyItem = new Sources.RevisionHistoryTreeElement(revision, history[i - 1], i !== revisionCount - 1);
uiSourceCodeItem.appendChild(historyItem);
}
@@ -133,9 +133,9 @@ Sources.RevisionHistoryView = class extends UI.VBox {
return;
}
- var historyLength = uiSourceCode.history.length;
- var historyItem = new Sources.RevisionHistoryTreeElement(
- uiSourceCode.history[historyLength - 1], uiSourceCode.history[historyLength - 2], false);
+ var history = uiSourceCode.history();
+ var historyItem =
+ new Sources.RevisionHistoryTreeElement(history[history.length - 1], history[history.length - 2], false);
if (uiSourceCodeItem.firstChild())
uiSourceCodeItem.firstChild().allowRevert();
uiSourceCodeItem.insertChild(historyItem, 0);

Powered by Google App Engine
This is Rietveld 408576698