third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/callstack-placards-discarded.html - Issue 2613643002: DevTools: migrate from external Maps to symbols in the bindings objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/callstack-placards-discarded.html

Issue 2613643002: DevTools: migrate from external Maps to symbols in the bindings objects. (Closed)

Patch Set: review comments addressed. Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-history.html ('k') | third_party/WebKit/LayoutTests/inspector/uisourcecode-revisions.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/callstack-placards-discarded.html

diff --git a/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/callstack-placards-discarded.html b/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/callstack-placards-discarded.html

index d716b6c307da6eb39d2881522cfe406112d63a74..16989e240fb71e90658c87e538f7d2fad7135e57 100644

--- a/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/callstack-placards-discarded.html

+++ b/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/callstack-placards-discarded.html

@@ -55,9 +55,9 @@ var test = function()

function liveLocationsCount()

{

var count = 0;

- var infos = Bindings.debuggerWorkspaceBinding._targetToData.get(InspectorTest.debuggerModel.target()).scriptDataMap.valuesArray();

+ var infos = Object.values(InspectorTest.debuggerModel.scripts).map(script => script[Bindings.DebuggerWorkspaceBinding._ScriptInfoSymbol]).filter(info => !!info);

infos.forEach(function(info) {

- count += info._locations.size;

+ count += info._locations ? info._locations.size : 0;

});

return count;

}