Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 2613583002: Remove skia::ScopedPlatformPaint (Closed)

Created:
3 years, 11 months ago by f(malita)
Modified:
3 years, 11 months ago
Reviewers:
danakj, sky, reed1
CC:
chromium-reviews, mac-reviews_chromium.org, jam, dcheng, jbauman+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove skia::ScopedPlatformPaint This helper no longer provides any scoped/RAII functionalty, and can be replaced with a GetNativeDrawingContext() function. BUG=675977 R=reed@google.com TBR=sky@chromium.org,danakj@chromium.org Committed: https://crrev.com/dfb527a33abfabb690802b64136156a867ccdbae Cr-Commit-Position: refs/heads/master@{#441367}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -72 lines) Patch
M content/browser/compositor/software_output_device_win.cc View 1 chunk +1 line, -2 lines 0 comments Download
M skia/ext/bitmap_platform_device_cairo.h View 2 chunks +0 lines, -9 lines 0 comments Download
M skia/ext/bitmap_platform_device_mac_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M skia/ext/bitmap_platform_device_skia.h View 2 chunks +0 lines, -4 lines 0 comments Download
M skia/ext/bitmap_platform_device_win.h View 2 chunks +0 lines, -3 lines 0 comments Download
M skia/ext/bitmap_platform_device_win.cc View 2 chunks +1 line, -2 lines 0 comments Download
M skia/ext/platform_canvas.h View 1 chunk +3 lines, -21 lines 0 comments Download
M skia/ext/platform_canvas.cc View 1 chunk +10 lines, -11 lines 0 comments Download
M skia/ext/platform_canvas_unittest.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M skia/ext/platform_device.h View 2 chunks +0 lines, -4 lines 0 comments Download
M ui/base/clipboard/clipboard_win.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/gfx/canvas_paint_mac.mm View 1 chunk +1 line, -2 lines 0 comments Download
M ui/native_theme/native_theme_win.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
f(malita)
3 years, 11 months ago (2017-01-03 20:49:51 UTC) #3
reed1
lgtm
3 years, 11 months ago (2017-01-03 20:51:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2613583002/1
3 years, 11 months ago (2017-01-04 14:08:05 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-04 14:15:48 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/dfb527a33abfabb690802b64136156a867ccdbae Cr-Commit-Position: refs/heads/master@{#441367}
3 years, 11 months ago (2017-01-04 14:18:29 UTC) #15
f(malita)
TBR-ing a few trivial/mechanical changes in content/browser/compositor and ui/.
3 years, 11 months ago (2017-01-04 14:28:28 UTC) #16
sky
ui LGTM
3 years, 11 months ago (2017-01-04 16:42:34 UTC) #17
danakj
3 years, 11 months ago (2017-01-04 18:59:45 UTC) #18
Message was sent while issue was closed.
c/b/c/ lgtm

Powered by Google App Engine
This is Rietveld 408576698