GN: avoid going through compiler wrapper for "link" tool for macOS/iOS.

GN: avoid going through compiler wrapper for "link" tool for macOS/iOS.

Stop going through goma (or other compiler wrapper) for the "link"
tool when building for macOS/iOS (to follow gcc_compiler.gni).

BUG=None

Review-Url: https://codereview.chromium.org/2613503002
Cr-Commit-Position: refs/heads/master@{#442245}
Committed: https://chromium.googlesource.com/chromium/src/+/5adef79d6f465dddc30e88db148c5b69c7059448

[sdefresne, 2017-01-03 16:30:05]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 16:30:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-01-03 16:56:28]

sdefresne@chromium.org changed reviewers:
+ brettw@chromium.org

[sdefresne, 2017-01-03 16:56:29]

Please take a look.

[sdefresne, 2017-01-03 17:31:40]

Description was changed from

==========
GN: avoid going through compiler wrapper for "link" tool for macOS/iOS.

Stop going through goma (or other compiler wrapper) for the "link"
tool when building for macOS/iOS (to follow gcc_compiler.gni).

BUG=None
==========

to

==========
GN: avoid going through compiler wrapper for "link" tool for macOS/iOS.

Stop going through goma (or other compiler wrapper) for the "link"
tool when building for macOS/iOS (to follow gcc_compiler.gni).

BUG=None
==========

[sdefresne, 2017-01-03 17:31:40]

sdefresne@chromium.org changed reviewers:
+ thakis@chromium.org

[commit-bot: I haz the power, 2017-01-03 17:47:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 17:47:44]

Dry run: This issue passed the CQ dry run.

[sdefresne, 2017-01-05 17:09:04]

Friendly ping :-)

[Nico, 2017-01-05 17:19:49]

lgtm

(tip: when pinging people, say e.g. "sdefresne: ping" instead of just "ping",
then you save the others cc'd the click to see if the ping was for them)

[sdefresne, 2017-01-05 17:25:08]

On 2017/01/05 17:19:49, Nico (ooo sick) wrote:
> lgtm
> 
> (tip: when pinging people, say e.g. "sdefresne: ping" instead of just "ping",
> then you save the others cc'd the click to see if the ping was for them)

That's a good point. I wanted to ping brettw@ (I forgot that I added you as a
reviewer without sending an email).
Thank you for the review.

[sdefresne, 2017-01-06 15:09:59]

brettw: ping

[brettw, 2017-01-06 18:42:20]

lgtm

[sdefresne, 2017-01-09 08:05:11]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2017-01-09 08:05:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 09:13:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 09:13:18]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sdefresne, 2017-01-09 09:23:49]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 09:24:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 09:49:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 09:49:02]

Dry run: This issue passed the CQ dry run.

[sdefresne, 2017-01-09 13:39:22]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2017-01-09 13:39:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-01-09 13:39:44]

On 2017/01/09 09:13:18, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Looks like a flake (as the next run passed). Sending back to CQ.

[commit-bot: I haz the power, 2017-01-09 13:43:01]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483969162839770, "parent_rev":
"62938a72f596f94b55e7c8f4f152b2460554e178", "commit_rev":
"5adef79d6f465dddc30e88db148c5b69c7059448"}

[commit-bot: I haz the power, 2017-01-09 13:43:30]

Description was changed from

==========
GN: avoid going through compiler wrapper for "link" tool for macOS/iOS.

Stop going through goma (or other compiler wrapper) for the "link"
tool when building for macOS/iOS (to follow gcc_compiler.gni).

BUG=None
==========

to

==========
GN: avoid going through compiler wrapper for "link" tool for macOS/iOS.

Stop going through goma (or other compiler wrapper) for the "link"
tool when building for macOS/iOS (to follow gcc_compiler.gni).

BUG=None

Review-Url: https://codereview.chromium.org/2613503002
Cr-Commit-Position: refs/heads/master@{#442245}
Committed:
https://chromium.googlesource.com/chromium/src/+/5adef79d6f465dddc30e88db148c...
==========

[commit-bot: I haz the power, 2017-01-09 13:43:30]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5adef79d6f465dddc30e88db148c...