Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Issue 2612583002: Remove ChromeBrowserProvider::CreateCardUnmaskPromptView(). (Closed)

Created:
3 years, 11 months ago by sdefresne
Modified:
3 years, 11 months ago
CC:
chromium-reviews, rouslan+autofill_chromium.org, sebsg+autofillwatch_chromium.org, pkl (ping after 24h if needed), mathp+autofillwatch_chromium.org, noyau+watch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ChromeBrowserProvider::CreateCardUnmaskPromptView(). The method can now be inlined at the call site as the implementation has been upstreamed. Removing the method and obsolete includes. BUG=676278 Committed: https://crrev.com/d78af33251a7c3bf28d9a45cb6b664da31c37b82 Cr-Commit-Position: refs/heads/master@{#441155}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix grammar in comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -43 lines) Patch
M ios/chrome/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/downstream_chromium_browser_provider.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ios/chrome/browser/downstream_chromium_browser_provider.mm View 2 chunks +0 lines, -7 lines 0 comments Download
M ios/chrome/browser/ui/autofill/BUILD.gn View 2 chunks +6 lines, -15 lines 0 comments Download
M ios/chrome/browser/ui/autofill/autofill_client_ios.mm View 1 2 chunks +5 lines, -3 lines 0 comments Download
M ios/public/provider/chrome/browser/chrome_browser_provider.h View 2 chunks +0 lines, -9 lines 0 comments Download
M ios/public/provider/chrome/browser/chrome_browser_provider.mm View 1 chunk +0 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (11 generated)
sdefresne
Please take a look and send to CQ if LGTY.
3 years, 11 months ago (2017-01-03 16:17:02 UTC) #3
rohitrao (ping after 24h)
lgtm https://codereview.chromium.org/2612583002/diff/1/ios/chrome/browser/ui/autofill/autofill_client_ios.mm File ios/chrome/browser/ui/autofill/autofill_client_ios.mm (right): https://codereview.chromium.org/2612583002/diff/1/ios/chrome/browser/ui/autofill/autofill_client_ios.mm#newcode82 ios/chrome/browser/ui/autofill/autofill_client_ios.mm:82: // autofill::CardUnmaskPromptViewBridge manages it's own lifetime, so Typo: ...
3 years, 11 months ago (2017-01-03 16:23:01 UTC) #5
sdefresne
Thank you. https://codereview.chromium.org/2612583002/diff/1/ios/chrome/browser/ui/autofill/autofill_client_ios.mm File ios/chrome/browser/ui/autofill/autofill_client_ios.mm (right): https://codereview.chromium.org/2612583002/diff/1/ios/chrome/browser/ui/autofill/autofill_client_ios.mm#newcode82 ios/chrome/browser/ui/autofill/autofill_client_ios.mm:82: // autofill::CardUnmaskPromptViewBridge manages it's own lifetime, so ...
3 years, 11 months ago (2017-01-03 16:59:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2612583002/20001
3 years, 11 months ago (2017-01-03 17:32:02 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2017-01-03 18:12:25 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 18:15:22 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d78af33251a7c3bf28d9a45cb6b664da31c37b82
Cr-Commit-Position: refs/heads/master@{#441155}

Powered by Google App Engine
This is Rietveld 408576698