Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2612733004: Renames SessionChanges and SessionCellData to have a TabSwitcher prefix. (Closed)

Created:
3 years, 11 months ago by rohitrao (ping after 24h)
Modified:
3 years, 11 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Renames SessionChanges and SessionCellData to have a TabSwitcher prefix. BUG=None Committed: https://crrev.com/756f137cb7c0df7c1f1090a027ee03335ffdd489 Cr-Commit-Position: refs/heads/master@{#441377}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -139 lines) Patch
M ios/chrome/browser/ui/tab_switcher/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
D ios/chrome/browser/ui/tab_switcher/session_changes.h View 1 chunk +0 lines, -42 lines 0 comments Download
D ios/chrome/browser/ui/tab_switcher/session_changes.mm View 1 chunk +0 lines, -31 lines 0 comments Download
M ios/chrome/browser/ui/tab_switcher/tab_switcher_controller.mm View 3 chunks +7 lines, -7 lines 0 comments Download
M ios/chrome/browser/ui/tab_switcher/tab_switcher_header_cell.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/tab_switcher/tab_switcher_header_cell.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/tab_switcher/tab_switcher_header_view.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/tab_switcher/tab_switcher_header_view.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/tab_switcher/tab_switcher_model.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/tab_switcher/tab_switcher_model_unittest.mm View 2 chunks +0 lines, -8 lines 0 comments Download
M ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_controller.mm View 5 chunks +8 lines, -8 lines 0 comments Download
M ios/chrome/browser/ui/tab_switcher/tab_switcher_session_cell_data.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/tab_switcher/tab_switcher_session_cell_data.mm View 3 chunks +4 lines, -4 lines 0 comments Download
A + ios/chrome/browser/ui/tab_switcher/tab_switcher_session_changes.h View 2 chunks +17 lines, -13 lines 0 comments Download
A + ios/chrome/browser/ui/tab_switcher/tab_switcher_session_changes.mm View 2 chunks +4 lines, -14 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (9 generated)
rohitrao (ping after 24h)
3 years, 11 months ago (2017-01-04 14:31:21 UTC) #4
sdefresne
lgtm
3 years, 11 months ago (2017-01-04 15:08:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2612733004/1
3 years, 11 months ago (2017-01-04 15:28:07 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/33dc4240b9e726e95dd733283c92f4f6c3f6d326
3 years, 11 months ago (2017-01-04 15:32:48 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 15:35:28 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/756f137cb7c0df7c1f1090a027ee03335ffdd489
Cr-Commit-Position: refs/heads/master@{#441377}

Powered by Google App Engine
This is Rietveld 408576698