[ios] Moves tab_switcher code out of the ios_internal namespace.

[ios] Moves tab_switcher code out of the ios_internal namespace.

Most of this CL was automated using the following commands:
tools/git/mffr.py -f ios_internal::SessionChanges SessionChanges
tools/git/mffr.py -f ios_internal::SessionType TabSwitcherSessionType

Also renames some methods to have less generic names, now that they are no
longer in the ios_internal namespace.

BUG=677941
Committed: https://crrev.com/aa323161b7a81feae271ad6b4f2d21a613380367
Cr-Commit-Position: refs/heads/master@{#441369}

[rohitrao (ping after 24h), 2017-01-03 15:45:05]

The CQ bit was checked by rohitrao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 15:45:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rohitrao (ping after 24h), 2017-01-03 15:46:32]

rohitrao@chromium.org changed reviewers:
+ jif@chromium.org, sdefresne@chromium.org

[rohitrao (ping after 24h), 2017-01-03 15:46:33]

https://codereview.chromium.org/2608253003/diff/1/ios/chrome/browser/ui/tab_s...
File ios/chrome/browser/ui/tab_switcher/tab_switcher_utils.h (right):

https://codereview.chromium.org/2608253003/diff/1/ios/chrome/browser/ui/tab_s...
ios/chrome/browser/ui/tab_switcher/tab_switcher_utils.h:20: void
TabSwitcherGetFavicon(GURL const& url,
This seems like a method that could move out of tab_switcher/, but I'm not sure
where it should move to.  Suggestions?

https://codereview.chromium.org/2608253003/diff/1/ios/chrome/browser/ui/tab_s...
ios/chrome/browser/ui/tab_switcher/tab_switcher_utils.h:36: void
TabSwitcherMinimalReplacementOperations(std::vector<size_t> const& initial,
Renamed this method to something less generic, because it's no longer in a
namespace.

[commit-bot: I haz the power, 2017-01-03 15:54:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 15:54:21]

Dry run: This issue passed the CQ dry run.

[sdefresne, 2017-01-03 16:04:30]

I think we should rename the SessionType and SessionCellType to
TabSwitcherSession{Type,CellType} to avoid confusion with components/sessions
(especially since some of the other types are named TabSwitcherFoo).

The changes to DCHECK() should probably be done in a separate CL.

https://codereview.chromium.org/2608253003/diff/1/ios/chrome/browser/ui/tab_s...
File ios/chrome/browser/ui/tab_switcher/tab_switcher_controller.mm (right):

https://codereview.chromium.org/2608253003/diff/1/ios/chrome/browser/ui/tab_s...
ios/chrome/browser/ui/tab_switcher/tab_switcher_controller.mm:1006: if (type ==
SessionType::REGULAR_SESSION) {
nit: it would be better to use a switch statement here I think (like in
-sizeForItemAtIndex:inSession: for example).

https://codereview.chromium.org/2608253003/diff/1/ios/chrome/browser/ui/tab_s...
File ios/chrome/browser/ui/tab_switcher/tab_switcher_model.h (right):

https://codereview.chromium.org/2608253003/diff/1/ios/chrome/browser/ui/tab_s...
ios/chrome/browser/ui/tab_switcher/tab_switcher_model.h:30: enum class
SessionType {
nit: maybe rename TabSwitcherSessionType?

https://codereview.chromium.org/2608253003/diff/1/ios/chrome/browser/ui/tab_s...
File ios/chrome/browser/ui/tab_switcher/tab_switcher_model.mm (right):

https://codereview.chromium.org/2608253003/diff/1/ios/chrome/browser/ui/tab_s...
ios/chrome/browser/ui/tab_switcher/tab_switcher_model.mm:153: DCHECK(type ==
SessionType::OFF_THE_RECORD_SESSION ||
nit: this could be rewritten like this

  DCHECK(SessionTypeIsLocalSession(type));

https://codereview.chromium.org/2608253003/diff/1/ios/chrome/browser/ui/tab_s...
File ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_controller.mm
(right):

https://codereview.chromium.org/2608253003/diff/1/ios/chrome/browser/ui/tab_s...
ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_controller.mm:265: if
(_sessionType == SessionType::DISTANT_SESSION) {
nit: why not "if (!SessionTypeIsLocalSession(_sessionType))"?

https://codereview.chromium.org/2608253003/diff/1/ios/chrome/browser/ui/tab_s...
ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_controller.mm:277:
DCHECK(_sessionType != SessionType::DISTANT_SESSION);
nit: why not "DCHECK(SessionTypeIsLocalSession(_sessionType));"?

https://codereview.chromium.org/2608253003/diff/1/ios/chrome/browser/ui/tab_s...
File ios/chrome/browser/ui/tab_switcher/tab_switcher_session_cell_data.h
(right):

https://codereview.chromium.org/2608253003/diff/1/ios/chrome/browser/ui/tab_s...
ios/chrome/browser/ui/tab_switcher/tab_switcher_session_cell_data.h:12: enum
SessionCellType {
nit: maybe rename TabSwitcherSessionCellType.

https://codereview.chromium.org/2608253003/diff/1/ios/chrome/browser/ui/tab_s...
File ios/chrome/browser/ui/tab_switcher/tab_switcher_utils.mm (right):

https://codereview.chromium.org/2608253003/diff/1/ios/chrome/browser/ui/tab_s...
ios/chrome/browser/ui/tab_switcher/tab_switcher_utils.mm:30:
std::vector<std::vector<int>> const& costMatrix,
nit: this is a C++ function so it should use
cpp_naming_convention_for_local_variables_and_parameters.

s/costMatrix/cost_matrix/
s/finalIndex/final_index/
...

[rohitrao (ping after 24h), 2017-01-04 13:36:17]

The CQ bit was checked by rohitrao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 13:36:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rohitrao (ping after 24h), 2017-01-04 13:36:38]

Renamed the enums, will address the more substantive changes in a followup.

https://codereview.chromium.org/2608253003/diff/1/ios/chrome/browser/ui/tab_s...
File ios/chrome/browser/ui/tab_switcher/tab_switcher_controller.mm (right):

https://codereview.chromium.org/2608253003/diff/1/ios/chrome/browser/ui/tab_s...
ios/chrome/browser/ui/tab_switcher/tab_switcher_controller.mm:1006: if (type ==
SessionType::REGULAR_SESSION) {
On 2017/01/03 16:04:30, sdefresne wrote:
> nit: it would be better to use a switch statement here I think (like in
> -sizeForItemAtIndex:inSession: for example).

Acknowledged.

https://codereview.chromium.org/2608253003/diff/1/ios/chrome/browser/ui/tab_s...
File ios/chrome/browser/ui/tab_switcher/tab_switcher_model.h (right):

https://codereview.chromium.org/2608253003/diff/1/ios/chrome/browser/ui/tab_s...
ios/chrome/browser/ui/tab_switcher/tab_switcher_model.h:30: enum class
SessionType {
On 2017/01/03 16:04:30, sdefresne wrote:
> nit: maybe rename TabSwitcherSessionType?

Done.

https://codereview.chromium.org/2608253003/diff/1/ios/chrome/browser/ui/tab_s...
File ios/chrome/browser/ui/tab_switcher/tab_switcher_model.mm (right):

https://codereview.chromium.org/2608253003/diff/1/ios/chrome/browser/ui/tab_s...
ios/chrome/browser/ui/tab_switcher/tab_switcher_model.mm:153: DCHECK(type ==
SessionType::OFF_THE_RECORD_SESSION ||
On 2017/01/03 16:04:30, sdefresne wrote:
> nit: this could be rewritten like this
> 
>   DCHECK(SessionTypeIsLocalSession(type));

Acknowledged.

https://codereview.chromium.org/2608253003/diff/1/ios/chrome/browser/ui/tab_s...
File ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_controller.mm
(right):

https://codereview.chromium.org/2608253003/diff/1/ios/chrome/browser/ui/tab_s...
ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_controller.mm:265: if
(_sessionType == SessionType::DISTANT_SESSION) {
On 2017/01/03 16:04:30, sdefresne wrote:
> nit: why not "if (!SessionTypeIsLocalSession(_sessionType))"?

Acknowledged.

https://codereview.chromium.org/2608253003/diff/1/ios/chrome/browser/ui/tab_s...
ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_controller.mm:277:
DCHECK(_sessionType != SessionType::DISTANT_SESSION);
On 2017/01/03 16:04:30, sdefresne wrote:
> nit: why not "DCHECK(SessionTypeIsLocalSession(_sessionType));"?

Acknowledged.

https://codereview.chromium.org/2608253003/diff/1/ios/chrome/browser/ui/tab_s...
File ios/chrome/browser/ui/tab_switcher/tab_switcher_session_cell_data.h
(right):

https://codereview.chromium.org/2608253003/diff/1/ios/chrome/browser/ui/tab_s...
ios/chrome/browser/ui/tab_switcher/tab_switcher_session_cell_data.h:12: enum
SessionCellType {
On 2017/01/03 16:04:30, sdefresne wrote:
> nit: maybe rename TabSwitcherSessionCellType.

Done.

https://codereview.chromium.org/2608253003/diff/1/ios/chrome/browser/ui/tab_s...
ios/chrome/browser/ui/tab_switcher/tab_switcher_session_cell_data.h:23:
@interface SessionCellData : NSObject
This class should perhaps also be renamed to TabSwitcherSessionCellData.

https://codereview.chromium.org/2608253003/diff/1/ios/chrome/browser/ui/tab_s...
File ios/chrome/browser/ui/tab_switcher/tab_switcher_utils.mm (right):

https://codereview.chromium.org/2608253003/diff/1/ios/chrome/browser/ui/tab_s...
ios/chrome/browser/ui/tab_switcher/tab_switcher_utils.mm:30:
std::vector<std::vector<int>> const& costMatrix,
On 2017/01/03 16:04:30, sdefresne wrote:
> nit: this is a C++ function so it should use
> cpp_naming_convention_for_local_variables_and_parameters.
> 
> s/costMatrix/cost_matrix/
> s/finalIndex/final_index/
> ...

Acknowledged.

[sdefresne, 2017-01-04 13:52:01]

lgtm but please update commands in the CL description :-)

[rohitrao (ping after 24h), 2017-01-04 13:58:07]

Description was changed from

==========
[ios] Moves tab_switcher code out of the ios_internal namespace.

Most of this CL was automated using the following commands:
tools/git/mffr.py -f ios_internal::SessionChanges SessionChanges
tools/git/mffr.py -f ios_internal::SessionType SessionType

Also renames some methods to have less generic names, now that they are no
longer in the ios_internal namespace.

BUG=677941
==========

to

==========
[ios] Moves tab_switcher code out of the ios_internal namespace.

Most of this CL was automated using the following commands:
tools/git/mffr.py -f ios_internal::SessionChanges SessionChanges
tools/git/mffr.py -f ios_internal::SessionType TabSwitcherSessionType

Also renames some methods to have less generic names, now that they are no
longer in the ios_internal namespace.

BUG=677941
==========

[commit-bot: I haz the power, 2017-01-04 14:18:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 14:18:51]

Dry run: This issue passed the CQ dry run.

[rohitrao (ping after 24h), 2017-01-04 14:25:05]

The CQ bit was checked by rohitrao@chromium.org

[commit-bot: I haz the power, 2017-01-04 14:25:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 14:29:17]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483539905434300,
"parent_rev": "414c241c07e65cdfeaa34f3e8cc25d20d622982e", "commit_rev":
"b956969b4e16f39aa3dd1ccc1f64e0eca03901d4"}

[commit-bot: I haz the power, 2017-01-04 14:29:44]

Description was changed from

==========
[ios] Moves tab_switcher code out of the ios_internal namespace.

Most of this CL was automated using the following commands:
tools/git/mffr.py -f ios_internal::SessionChanges SessionChanges
tools/git/mffr.py -f ios_internal::SessionType TabSwitcherSessionType

Also renames some methods to have less generic names, now that they are no
longer in the ios_internal namespace.

BUG=677941
==========

to

==========
[ios] Moves tab_switcher code out of the ios_internal namespace.

Most of this CL was automated using the following commands:
tools/git/mffr.py -f ios_internal::SessionChanges SessionChanges
tools/git/mffr.py -f ios_internal::SessionType TabSwitcherSessionType

Also renames some methods to have less generic names, now that they are no
longer in the ios_internal namespace.

BUG=677941

Review-Url: https://codereview.chromium.org/2608253003
==========

[commit-bot: I haz the power, 2017-01-04 14:29:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2017-01-04 14:34:07]

Description was changed from

==========
[ios] Moves tab_switcher code out of the ios_internal namespace.

Most of this CL was automated using the following commands:
tools/git/mffr.py -f ios_internal::SessionChanges SessionChanges
tools/git/mffr.py -f ios_internal::SessionType TabSwitcherSessionType

Also renames some methods to have less generic names, now that they are no
longer in the ios_internal namespace.

BUG=677941

Review-Url: https://codereview.chromium.org/2608253003
==========

to

==========
[ios] Moves tab_switcher code out of the ios_internal namespace.

Most of this CL was automated using the following commands:
tools/git/mffr.py -f ios_internal::SessionChanges SessionChanges
tools/git/mffr.py -f ios_internal::SessionType TabSwitcherSessionType

Also renames some methods to have less generic names, now that they are no
longer in the ios_internal namespace.

BUG=677941

Committed: https://crrev.com/aa323161b7a81feae271ad6b4f2d21a613380367
Cr-Commit-Position: refs/heads/master@{#441369}
==========

[commit-bot: I haz the power, 2017-01-04 14:34:08]

Patchset 2 (id:??) landed as
https://crrev.com/aa323161b7a81feae271ad6b4f2d21a613380367
Cr-Commit-Position: refs/heads/master@{#441369}