Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2612773002: [ios] Style cleanups in tab switcher code.

Created:
3 years, 11 months ago by rohitrao (ping after 24h)
Modified:
3 years, 6 months ago
Reviewers:
jif, sdefresne
CC:
chromium-reviews, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Style cleanups in tab switcher code. BUG=None

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -61 lines) Patch
M ios/chrome/browser/ui/tab_switcher/tab_switcher_controller.mm View 1 chunk +10 lines, -5 lines 0 comments Download
M ios/chrome/browser/ui/tab_switcher/tab_switcher_model.mm View 1 chunk +1 line, -2 lines 0 comments Download
M ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_controller.mm View 1 chunk +6 lines, -6 lines 0 comments Download
M ios/chrome/browser/ui/tab_switcher/tab_switcher_utils.mm View 3 chunks +51 lines, -48 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (5 generated)
rohitrao (ping after 24h)
Cleanups suggested in https://codereview.chromium.org/2608253003. Will wait for jif@ to return and be the primary reviewer ...
3 years, 11 months ago (2017-01-04 14:32:32 UTC) #4
jif
a million times lgtm.
3 years, 11 months ago (2017-01-13 18:26:58 UTC) #7
sdefresne
What is the status of this CL? Should it land? Should it be closed?
3 years, 7 months ago (2017-05-03 09:12:33 UTC) #8
sdefresne
3 years, 6 months ago (2017-06-15 09:41:01 UTC) #9
On 2017/05/03 09:12:33, sdefresne wrote:
> What is the status of this CL? Should it land? Should it be closed?

rohitrao: ping?

Powered by Google App Engine
This is Rietveld 408576698