Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 2612243003: Supporting study definitions without default groups and end_date filtering. (Closed)

Created:
3 years, 11 months ago by jwd
Modified:
3 years, 11 months ago
Reviewers:
rkaplow
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Supporting study definitions without default groups and end_date filtering. Reland of https://codereview.chromium.org/2614443002, which was reverted due to static initializer. end_date is a replacement for expiry_date, which is deprecated by this change. The difference is that end_date is acts as a normal filter, and causes study to not be created when the date is past. expiry_date caused the study to be created, and forced to the default group. This change introduces a generic default group name, which is used for the field trial API when a study doesn't specify one. BUG=677976 Review-Url: https://codereview.chromium.org/2612243003 Cr-Commit-Position: refs/heads/master@{#441976} Committed: https://chromium.googlesource.com/chromium/src/+/5ff54103eeded8b0a3741320e39bb1cc029ba1ca

Patch Set 1 #

Patch Set 2 : removing static initializer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -17 lines) Patch
M components/variations/processed_study.h View 1 2 chunks +8 lines, -0 lines 0 comments Download
M components/variations/processed_study.cc View 1 4 chunks +16 lines, -8 lines 0 comments Download
M components/variations/proto/study.proto View 3 chunks +13 lines, -2 lines 0 comments Download
M components/variations/study_filtering.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/variations/study_filtering.cc View 2 chunks +15 lines, -0 lines 0 comments Download
M components/variations/study_filtering_unittest.cc View 3 chunks +30 lines, -4 lines 0 comments Download
M components/variations/variations_seed_processor.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/variations/variations_seed_processor_unittest.cc View 1 2 chunks +20 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
jwd
3 years, 11 months ago (2017-01-05 22:04:50 UTC) #3
rkaplow
lgtm
3 years, 11 months ago (2017-01-06 15:39:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2612243003/20001
3 years, 11 months ago (2017-01-06 16:10:53 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 18:10:14 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5ff54103eeded8b0a3741320e39b...

Powered by Google App Engine
This is Rietveld 408576698