Supporting study definitions without default groups and end_date filtering.

Supporting study definitions without default groups and end_date filtering.

end_date is a replacement for expiry_date, which is deprecated by this change. The difference is that end_date is acts as a normal filter, and causes study to not be created when the date is past. expiry_date caused the study to be created, and forced to the default group.

This change introduces a generic default group name, which is used for the field trial API when a study doesn't specify one.

BUG=677976
Committed: https://crrev.com/49d24a0cc2a73773f3ee72b4d242d6fad8c57254
Cr-Commit-Position: refs/heads/master@{#441487}

[jwd, 2017-01-03 16:22:09]

Patchset #1 (id:1) has been deleted

[jwd, 2017-01-03 16:32:45]

Description was changed from

==========
Supporting study definitions without default groups.

BUG=
==========

to

==========
Supporting study definitions without default groups and end_date filtering.

end_date is a replacement for expiry_date, which is deprecated by this change.
The difference is that end_date is acts as a normal filter, and causes study to
not be created when the date is past. expiry_date caused the study to be
created, and forced to the default group.

This change introduces a generic default group name, which is used for the field
trial API when a study doesn't specify one.

BUG=677976
==========

[jwd, 2017-01-03 16:33:13]

jwd@chromium.org changed reviewers:
+ rkaplow@chromium.org

[jwd, 2017-01-03 18:18:06]

The CQ bit was checked by jwd@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 18:18:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 19:51:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 19:51:15]

Dry run: This issue passed the CQ dry run.

[rkaplow, 2017-01-04 15:58:25]

lgtm

https://codereview.chromium.org/2614443002/diff/20001/components/variations/p...
File components/variations/processed_study.cc (right):

https://codereview.chromium.org/2614443002/diff/20001/components/variations/p...
components/variations/processed_study.cc:93: DVLOG(1) << study.name() << " is
missing default experiment in its "
optional, could add default_group_name to the DVLOG

https://codereview.chromium.org/2614443002/diff/20001/components/variations/p...
File components/variations/proto/study.proto (right):

https://codereview.chromium.org/2614443002/diff/20001/components/variations/p...
components/variations/proto/study.proto:43: // named "variations_dummy_default"
is used, and will have a probability
this isn't the name you put above

https://codereview.chromium.org/2614443002/diff/20001/components/variations/s...
File components/variations/study_filtering_unittest.cc (right):

https://codereview.chromium.org/2614443002/diff/20001/components/variations/s...
components/variations/study_filtering_unittest.cc:262: // Start date not set
should result in true.
End

[jwd, 2017-01-04 21:10:09]

Patchset #2 (id:40001) has been deleted

[jwd, 2017-01-04 21:10:15]

Patchset #2 (id:60001) has been deleted

[jwd, 2017-01-04 21:10:23]

https://codereview.chromium.org/2614443002/diff/20001/components/variations/p...
File components/variations/processed_study.cc (right):

https://codereview.chromium.org/2614443002/diff/20001/components/variations/p...
components/variations/processed_study.cc:93: DVLOG(1) << study.name() << " is
missing default experiment in its "
On 2017/01/04 15:58:25, rkaplow wrote:
> optional, could add default_group_name to the DVLOG

Done.

https://codereview.chromium.org/2614443002/diff/20001/components/variations/p...
File components/variations/proto/study.proto (right):

https://codereview.chromium.org/2614443002/diff/20001/components/variations/p...
components/variations/proto/study.proto:43: // named "variations_dummy_default"
is used, and will have a probability
On 2017/01/04 15:58:25, rkaplow wrote:
> this isn't the name you put above

Done.

https://codereview.chromium.org/2614443002/diff/20001/components/variations/s...
File components/variations/study_filtering_unittest.cc (right):

https://codereview.chromium.org/2614443002/diff/20001/components/variations/s...
components/variations/study_filtering_unittest.cc:262: // Start date not set
should result in true.
On 2017/01/04 15:58:25, rkaplow wrote:
> End

Done.

[jwd, 2017-01-04 21:23:34]

The CQ bit was checked by jwd@chromium.org

[jwd, 2017-01-04 21:23:34]

The patchset sent to the CQ was uploaded after l-g-t-m from rkaplow@chromium.org
Link to the patchset: https://codereview.chromium.org/2614443002/#ps80001
(title: "rkaplow's comments")

[commit-bot: I haz the power, 2017-01-04 21:24:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 22:22:11]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1483565014335560,
"parent_rev": "18a0b43d7ec95224d725576c5915ff68bbabd613", "commit_rev":
"960bdd5d419ddce259ee4b3cd8816f22be0cf2ce"}

[commit-bot: I haz the power, 2017-01-04 22:22:37]

Description was changed from

==========
Supporting study definitions without default groups and end_date filtering.

end_date is a replacement for expiry_date, which is deprecated by this change.
The difference is that end_date is acts as a normal filter, and causes study to
not be created when the date is past. expiry_date caused the study to be
created, and forced to the default group.

This change introduces a generic default group name, which is used for the field
trial API when a study doesn't specify one.

BUG=677976
==========

to

==========
Supporting study definitions without default groups and end_date filtering.

end_date is a replacement for expiry_date, which is deprecated by this change.
The difference is that end_date is acts as a normal filter, and causes study to
not be created when the date is past. expiry_date caused the study to be
created, and forced to the default group.

This change introduces a generic default group name, which is used for the field
trial API when a study doesn't specify one.

BUG=677976

Review-Url: https://codereview.chromium.org/2614443002
==========

[commit-bot: I haz the power, 2017-01-04 22:22:38]

Committed patchset #2 (id:80001)

[commit-bot: I haz the power, 2017-01-04 22:24:26]

Description was changed from

==========
Supporting study definitions without default groups and end_date filtering.

end_date is a replacement for expiry_date, which is deprecated by this change.
The difference is that end_date is acts as a normal filter, and causes study to
not be created when the date is past. expiry_date caused the study to be
created, and forced to the default group.

This change introduces a generic default group name, which is used for the field
trial API when a study doesn't specify one.

BUG=677976

Review-Url: https://codereview.chromium.org/2614443002
==========

to

==========
Supporting study definitions without default groups and end_date filtering.

end_date is a replacement for expiry_date, which is deprecated by this change.
The difference is that end_date is acts as a normal filter, and causes study to
not be created when the date is past. expiry_date caused the study to be
created, and forced to the default group.

This change introduces a generic default group name, which is used for the field
trial API when a study doesn't specify one.

BUG=677976

Committed: https://crrev.com/49d24a0cc2a73773f3ee72b4d242d6fad8c57254
Cr-Commit-Position: refs/heads/master@{#441487}
==========

[commit-bot: I haz the power, 2017-01-04 22:24:27]

Patchset 2 (id:??) landed as
https://crrev.com/49d24a0cc2a73773f3ee72b4d242d6fad8c57254
Cr-Commit-Position: refs/heads/master@{#441487}

[Devlin, 2017-01-04 23:13:46]

rdevlin.cronin@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[Devlin, 2017-01-04 23:13:46]

https://codereview.chromium.org/2614443002/diff/80001/components/variations/p...
File components/variations/processed_study.cc (right):

https://codereview.chromium.org/2614443002/diff/80001/components/variations/p...
components/variations/processed_study.cc:114: const std::string
ProcessedStudy::kGenericDefaultExperimentName =
non-POD statics aren't allowed (this resulted in a 'sizes' failure on linux)

[Devlin, 2017-01-04 23:14:06]

A revert of this CL (patchset #2 id:80001) has been created in
https://codereview.chromium.org/2615763002/ by rdevlin.cronin@chromium.org.

The reason for reverting is: Sheriff: Broke sizes on linux (see comment in CL).