Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: components/variations/proto/study.proto

Issue 2612243003: Supporting study definitions without default groups and end_date filtering. (Closed)
Patch Set: removing static initializer Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/variations/processed_study.cc ('k') | components/variations/study_filtering.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/variations/proto/study.proto
diff --git a/components/variations/proto/study.proto b/components/variations/proto/study.proto
index c97dbb4fff33771b20980b0b5a725761abf2886f..2b2f61162f17e855c2afcfbde031fb730ea8ab50 100644
--- a/components/variations/proto/study.proto
+++ b/components/variations/proto/study.proto
@@ -17,6 +17,7 @@ message Study {
// Ex: "my_study"
required string name = 1;
+ // DEPRECATED: Prefer end_date instead.
// The expiry date of the study in Unix time format. (Seconds since midnight
// January 1, 1970 UTC). See: http://en.wikipedia.org/wiki/Unix_time
//
@@ -38,7 +39,8 @@ message Study {
optional Consistency consistency = 7 [default = SESSION];
// Name of the experiment that gets the default experience. This experiment
- // must be included in the list below.
+ // must be included in the list below. If not specified, a generic default
+ // experiment name is used.
// Ex: "default"
optional string default_experiment_name = 8;
@@ -198,13 +200,22 @@ message Study {
// Filtering criteria specifying whether this study is applicable to a given
// Chrome instance.
//
- // Next tag: 13
+ // Next tag: 14
message Filter {
// The start date of the study in Unix time format. (Seconds since midnight
// January 1, 1970 UTC). See: http://en.wikipedia.org/wiki/Unix_time
// Ex: 1330893974 (corresponds to 2012-03-04 20:46:14Z)
optional int64 start_date = 1;
+ // The end date of the study in Unix time format. (Seconds since midnight
+ // January 1, 1970 UTC). See: http://en.wikipedia.org/wiki/Unix_time
+ // Ex: 1330893974 (corresponds to 2012-03-04 20:46:14Z)
+ // Mutually exclusive with expiry_date. The difference between end_date and
+ // expiry_date is that, when end_date is past, the field trial will not be
+ // created. When expiry_date is past, the trial is still created, but will
+ // be disabled, causing it to select its default group.
+ optional int64 end_date = 13;
+
// The minimum Chrome version for this study, allowing a trailing '*'
// character for pattern matching. Inclusive. (To check for a match, iterate
// over each component checking >= until a * or end of string is reached.)
« no previous file with comments | « components/variations/processed_study.cc ('k') | components/variations/study_filtering.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698