Implements CSSPropertyAPI for the paint-order property.

Implements CSSPropertyAPI for the paint-order property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyPaintOrder from the switch statement in parseSingleValue,
and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIPaintOrder.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIPaintOrder.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIPaintOrder.cpp, which implements CSSPropertyAPI.h.

BUG=668012
Review-Url: https://codereview.chromium.org/2612103003
Cr-Commit-Position: refs/heads/master@{#442890}
Committed: https://chromium.googlesource.com/chromium/src/+/dee07d3fac1402155ac4a17245501b6096605b9f

[aazzam, 2017-01-05 04:01:57]

aazzam@google.com changed reviewers:
+ alancutter@chromium.org

[alancutter (OOO until 2018), 2017-01-05 04:22:35]

lgtm

[aazzam, 2017-01-05 04:38:00]

Description was changed from

==========
Implemented CSSPropertyAPI for paint-order property.

Added CSSPropertyAPIPaintOrder which implements CSSPropertyAPI for
the paint-order property. Moved parsing logic from CSSPropertyParser
to the .cpp file. Added flag to CSSProperties.in so that the .h file
will be generated.

BUG=668012
==========

to

==========
Implemented CSSPropertyAPI for paint-order property.

Added CSSPropertyAPIPaintOrder which implements CSSPropertyAPI for
the paint-order property. Parsing logic is the same as before, 
just was moved from CSSPropertyParser to the .cpp file. Added flag 
to CSSProperties.in so that the .h file will be generated.

BUG=668012
==========

[aazzam, 2017-01-06 03:20:06]

aazzam@google.com changed reviewers:
+ sashab@chromium.org

[aazzam, 2017-01-06 03:20:06]

sashab rs lgtm please :)

[sashab, 2017-01-06 05:17:32]

lgtm

https://codereview.chromium.org/2612103003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/properties/CSSPropertyAPIPaintOrder.cpp
(right):

https://codereview.chromium.org/2612103003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIPaintOrder.cpp:7:
#include "core/css/CSSValueList.h"
Even though it's compiling without it, add CSSIdentifierValue.h since you use it
in this file :)

https://codereview.chromium.org/2612103003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIPaintOrder.cpp:58:
NOTREACHED();
Thanks for updating these

[aazzam, 2017-01-08 02:18:56]

Description was changed from

==========
Implemented CSSPropertyAPI for paint-order property.

Added CSSPropertyAPIPaintOrder which implements CSSPropertyAPI for
the paint-order property. Parsing logic is the same as before, 
just was moved from CSSPropertyParser to the .cpp file. Added flag 
to CSSProperties.in so that the .h file will be generated.

BUG=668012
==========

to

==========
Implements CSSPropertyAPI for the paint-order property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyPaintOrder from the switch statement in parseSingleValue,
and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIPaintOrder.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIPaintOrder.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIPaintOrder.cpp, which implements CSSPropertyAPI.h.

BUG=668012
==========

[aazzam, 2017-01-10 00:13:44]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 00:15:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 00:20:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 00:20:54]

Dry run: Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[aazzam, 2017-01-11 02:03:39]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 02:04:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 02:18:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 02:18:43]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[aazzam, 2017-01-11 02:30:55]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 02:31:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 02:34:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 02:34:24]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[aazzam, 2017-01-11 06:28:42]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 06:29:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 07:55:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 07:55:37]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[aazzam, 2017-01-11 12:10:55]

The CQ bit was checked by aazzam@google.com

[aazzam, 2017-01-11 12:10:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
alancutter@chromium.org, sashab@chromium.org
Link to the patchset: https://codereview.chromium.org/2612103003/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2017-01-11 12:11:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 13:28:21]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484136655406660,
"parent_rev": "6ae8701294c705c937e2955482e11a67aac089b3", "commit_rev":
"dee07d3fac1402155ac4a17245501b6096605b9f"}

[commit-bot: I haz the power, 2017-01-11 13:28:50]

Description was changed from

==========
Implements CSSPropertyAPI for the paint-order property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyPaintOrder from the switch statement in parseSingleValue,
and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIPaintOrder.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIPaintOrder.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIPaintOrder.cpp, which implements CSSPropertyAPI.h.

BUG=668012
==========

to

==========
Implements CSSPropertyAPI for the paint-order property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyPaintOrder from the switch statement in parseSingleValue,
and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIPaintOrder.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIPaintOrder.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIPaintOrder.cpp, which implements CSSPropertyAPI.h.

BUG=668012

Review-Url: https://codereview.chromium.org/2612103003
Cr-Commit-Position: refs/heads/master@{#442890}
Committed:
https://chromium.googlesource.com/chromium/src/+/dee07d3fac1402155ac4a1724550...
==========

[commit-bot: I haz the power, 2017-01-11 13:28:51]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/dee07d3fac1402155ac4a1724550...