Implements CSSPropertyAPI for the page property.

Implements CSSPropertyAPI for the page property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyPage from the switch statement in parseSingleValue, and
calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIPage.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIPage.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIPage.cpp, which implements CSSPropertyAPI.h.

BUG=668012
Review-Url: https://codereview.chromium.org/2618523003
Cr-Commit-Position: refs/heads/master@{#442879}
Committed: https://chromium.googlesource.com/chromium/src/+/f812e777f77f24979571a28472c064efade8ede8

[aazzam, 2017-01-05 04:14:32]

aazzam@google.com changed reviewers:
+ bugsnash@chromium.org

[aazzam, 2017-01-05 04:34:31]

Description was changed from

==========
Implemented CSSPropertyAPI for page property.

Added CSSPropertyAPIPage which implements CSSPropertyAPI for
the page property. Moved parsing logic from CSSPropertyParser
to the .cpp file. Added flag to CSSProperties.in so that the .h file
will be generated.

BUG=668012
==========

to

==========
Implemented CSSPropertyAPI for page property.

Added CSSPropertyAPIPage which implements CSSPropertyAPI for
the page property. Parsing logic is the same as before, just
was moved from CSSPropertyParser to the .cpp file. Added flag 
to CSSProperties.in so that the .h file will be generated.

BUG=668012
==========

[Bugs Nash, 2017-01-05 23:04:16]

https://codereview.chromium.org/2618523003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/properties/CSSPropertyAPIPage.cpp
(right):

https://codereview.chromium.org/2618523003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIPage.cpp:7: #include
"core/css/CSSValueList.h"
not needed

https://codereview.chromium.org/2618523003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIPage.cpp:8: #include
"core/css/parser/CSSParserTokenRange.h"
can be forward declared instead of included

[aazzam, 2017-01-08 02:42:12]

Description was changed from

==========
Implemented CSSPropertyAPI for page property.

Added CSSPropertyAPIPage which implements CSSPropertyAPI for
the page property. Parsing logic is the same as before, just
was moved from CSSPropertyParser to the .cpp file. Added flag 
to CSSProperties.in so that the .h file will be generated.

BUG=668012
==========

to

==========
Implements CSSPropertyAPI for the page property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyPage from the switch statement in parseSingleValue, and
calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIPage.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIPage.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIPage.cpp, which implements CSSPropertyAPI.h.

BUG=668012
==========

[aazzam, 2017-01-08 02:42:24]

aazzam@google.com changed reviewers:
+ sashab@chromium.org

[aazzam, 2017-01-08 02:42:25]

https://codereview.chromium.org/2618523003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/properties/CSSPropertyAPIPage.cpp
(right):

https://codereview.chromium.org/2618523003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIPage.cpp:7: #include
"core/css/CSSValueList.h"
On 2017/01/05 at 23:04:16, Bugs Nash wrote:
> not needed

removed :)

https://codereview.chromium.org/2618523003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIPage.cpp:8: #include
"core/css/parser/CSSParserTokenRange.h"
On 2017/01/05 at 23:04:16, Bugs Nash wrote:
> can be forward declared instead of included

fixed!

[Bugs Nash, 2017-01-08 20:14:04]

lgtm

[sashab, 2017-01-09 03:35:05]

lgtm

[aazzam, 2017-01-10 00:13:39]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 00:15:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 00:20:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 00:20:57]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[aazzam, 2017-01-11 02:02:15]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 02:02:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 02:17:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 02:17:08]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[aazzam, 2017-01-11 02:30:50]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 02:31:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 02:52:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 02:52:33]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[aazzam, 2017-01-11 06:28:38]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 06:28:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 08:01:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 08:01:10]

Dry run: This issue passed the CQ dry run.

[aazzam, 2017-01-11 12:05:33]

The CQ bit was checked by aazzam@google.com

[aazzam, 2017-01-11 12:05:33]

The patchset sent to the CQ was uploaded after l-g-t-m from sashab@chromium.org,
bugsnash@chromium.org
Link to the patchset: https://codereview.chromium.org/2618523003/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2017-01-11 12:05:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 12:09:53]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484136333425370,
"parent_rev": "15f17c04d930aa9499fa0b323fa6fd9bc1c7edbc", "commit_rev":
"f812e777f77f24979571a28472c064efade8ede8"}

[commit-bot: I haz the power, 2017-01-11 12:10:25]

Description was changed from

==========
Implements CSSPropertyAPI for the page property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyPage from the switch statement in parseSingleValue, and
calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIPage.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIPage.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIPage.cpp, which implements CSSPropertyAPI.h.

BUG=668012
==========

to

==========
Implements CSSPropertyAPI for the page property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyPage from the switch statement in parseSingleValue, and
calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIPage.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIPage.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIPage.cpp, which implements CSSPropertyAPI.h.

BUG=668012

Review-Url: https://codereview.chromium.org/2618523003
Cr-Commit-Position: refs/heads/master@{#442879}
Committed:
https://chromium.googlesource.com/chromium/src/+/f812e777f77f24979571a28472c0...
==========

[commit-bot: I haz the power, 2017-01-11 12:10:26]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/f812e777f77f24979571a28472c0...