Implements CSSPropertyAPI for the rotate property.

Implements CSSPropertyAPI for the rotate property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyRotate from the switch statement in parseSingleValue,
and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIRotate.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIRotate.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIRotate.cpp, which implements CSSPropertyAPI.h.

BUG=668012
Review-Url: https://codereview.chromium.org/2614833003
Cr-Commit-Position: refs/heads/master@{#443418}
Committed: https://chromium.googlesource.com/chromium/src/+/54cb2328f73f4c3ade73842a1ada9de6638b7113

[aazzam, 2017-01-05 04:02:13]

aazzam@google.com changed reviewers:
+ alancutter@chromium.org

[alancutter (OOO until 2018), 2017-01-05 04:22:01]

lgtm

[aazzam, 2017-01-05 04:37:41]

Description was changed from

==========
Implemented CSSPropertyAPI for rotate property.

Added CSSPropertyAPIRotate which implements CSSPropertyAPI for
the rotate property. Moved parsing logic from CSSPropertyParser
to the .cpp file. Added flag to CSSProperties.in so that the .h file
will be generated.

BUG=668012
==========

to

==========
Implemented CSSPropertyAPI for rotate property.

Added CSSPropertyAPIRotate which implements CSSPropertyAPI for
the rotate property. Parsing logic is the same as before, just
was moved from CSSPropertyParser to the .cpp file. Added flag 
to CSSProperties.in so that the .h file will be generated.

BUG=668012
==========

[aazzam, 2017-01-06 03:19:51]

aazzam@google.com changed reviewers:
+ sashab@chromium.org

[aazzam, 2017-01-06 03:19:51]

sashab rs lgtm please :)

[sashab, 2017-01-06 05:19:25]

https://codereview.chromium.org/2614833003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/CSSProperties.in (right):

https://codereview.chromium.org/2614833003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSProperties.in:393: translate
runtime_flag=CSSIndependentTransformProperties, converter=convertTranslate,
interpolable
hmm something not right here... Make sure you're not taking api_class off
translate

[sashab, 2017-01-06 05:19:36]

LGTM after rebase fix

[aazzam, 2017-01-08 02:17:22]

Description was changed from

==========
Implemented CSSPropertyAPI for rotate property.

Added CSSPropertyAPIRotate which implements CSSPropertyAPI for
the rotate property. Parsing logic is the same as before, just
was moved from CSSPropertyParser to the .cpp file. Added flag 
to CSSProperties.in so that the .h file will be generated.

BUG=668012
==========

to

==========
Implements CSSPropertyAPI for the rotate property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyRotate from the switch statement in parseSingleValue,
and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIRotate.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIRotate.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIRotate.cpp, which implements CSSPropertyAPI.h.

BUG=668012
==========

[aazzam, 2017-01-10 00:14:10]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 00:15:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 00:20:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 00:20:55]

Dry run: Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[aazzam, 2017-01-11 02:04:44]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 02:05:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 02:20:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 02:20:02]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[aazzam, 2017-01-11 02:31:02]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 02:32:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 02:35:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 02:35:45]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[aazzam, 2017-01-11 06:28:49]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 06:29:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 07:45:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 07:45:12]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[aazzam, 2017-01-11 20:07:39]

The CQ bit was checked by aazzam@google.com

[aazzam, 2017-01-11 20:07:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
alancutter@chromium.org, sashab@chromium.org
Link to the patchset: https://codereview.chromium.org/2614833003/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2017-01-11 20:08:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 20:34:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 20:34:47]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[aazzam, 2017-01-12 03:00:39]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 03:00:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aazzam, 2017-01-12 03:04:58]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 03:05:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 03:13:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 03:13:50]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[aazzam, 2017-01-12 04:17:50]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 04:18:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 06:43:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 06:43:22]

Dry run: This issue passed the CQ dry run.

[aazzam, 2017-01-12 11:05:42]

The CQ bit was checked by aazzam@google.com

[aazzam, 2017-01-12 11:05:42]

The patchset sent to the CQ was uploaded after l-g-t-m from sashab@chromium.org,
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/2614833003/#ps100001
(title: "re-added translate")

[commit-bot: I haz the power, 2017-01-12 11:05:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 11:09:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 11:09:14]

Failed to apply patch for third_party/WebKit/Source/core/css/CSSProperties.in:
While running git apply --index -p1;
  error: patch failed: third_party/WebKit/Source/core/css/CSSProperties.in:391
  error: third_party/WebKit/Source/core/css/CSSProperties.in: patch does not
apply

Patch:       third_party/WebKit/Source/core/css/CSSProperties.in
Index: third_party/WebKit/Source/core/css/CSSProperties.in
diff --git a/third_party/WebKit/Source/core/css/CSSProperties.in
b/third_party/WebKit/Source/core/css/CSSProperties.in
index
e67c54fc2254a8cae92711023975ce0814c7ae36..950260b1aa77bd9a3b72937618f6802d7c54eb2a
100644
--- a/third_party/WebKit/Source/core/css/CSSProperties.in
+++ b/third_party/WebKit/Source/core/css/CSSProperties.in
@@ -391,7 +391,7 @@ transform typedom_types=[Transform], keywords=[none],
interpolable, converter=co
 transform-origin interpolable, converter=convertTransformOrigin, api_class
 transform-style name_for_methods=TransformStyle3D
 translate runtime_flag=CSSIndependentTransformProperties,
converter=convertTranslate, interpolable, api_class
-rotate runtime_flag=CSSIndependentTransformProperties, converter=convertRotate,
interpolable
+rotate runtime_flag=CSSIndependentTransformProperties, converter=convertRotate,
interpolable, api_class
 scale runtime_flag=CSSIndependentTransformProperties, converter=convertScale,
interpolable
 unicode-bidi type_name=UnicodeBidi
 vector-effect svg

[aazzam, 2017-01-12 22:16:31]

The CQ bit was checked by aazzam@google.com

[aazzam, 2017-01-12 22:16:32]

The patchset sent to the CQ was uploaded after l-g-t-m from sashab@chromium.org,
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/2614833003/#ps120001
(title: "rebase")

[commit-bot: I haz the power, 2017-01-12 22:17:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 00:46:38]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1484259391964340,
"parent_rev": "456acc90587baec5eac79f0273d46145f6712cf7", "commit_rev":
"54cb2328f73f4c3ade73842a1ada9de6638b7113"}

[commit-bot: I haz the power, 2017-01-13 00:47:09]

Description was changed from

==========
Implements CSSPropertyAPI for the rotate property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyRotate from the switch statement in parseSingleValue,
and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIRotate.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIRotate.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIRotate.cpp, which implements CSSPropertyAPI.h.

BUG=668012
==========

to

==========
Implements CSSPropertyAPI for the rotate property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyRotate from the switch statement in parseSingleValue,
and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIRotate.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIRotate.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIRotate.cpp, which implements CSSPropertyAPI.h.

BUG=668012

Review-Url: https://codereview.chromium.org/2614833003
Cr-Commit-Position: refs/heads/master@{#443418}
Committed:
https://chromium.googlesource.com/chromium/src/+/54cb2328f73f4c3ade73842a1ada...
==========

[commit-bot: I haz the power, 2017-01-13 00:47:11]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/54cb2328f73f4c3ade73842a1ada...