Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: ios/chrome/browser/ui/tab_switcher/tab_switcher_transition_context.mm

Issue 2610923005: Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)
Patch Set: weak -> assign Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/tab_switcher/tab_switcher_transition_context.mm
diff --git a/ios/chrome/browser/ui/tab_switcher/tab_switcher_transition_context.mm b/ios/chrome/browser/ui/tab_switcher/tab_switcher_transition_context.mm
index 7968e3ce70a502df2f99846b5d26cb8d4646e928..5b59b43a3d3f26688e23436377c7d87ff2fdbd54 100644
--- a/ios/chrome/browser/ui/tab_switcher/tab_switcher_transition_context.mm
+++ b/ios/chrome/browser/ui/tab_switcher/tab_switcher_transition_context.mm
@@ -4,7 +4,7 @@
#include "ios/chrome/browser/ui/tab_switcher/tab_switcher_transition_context.h"
-#include "base/mac/objc_property_releaser.h"
+#include "base/mac/objc_release_properties.h"
#import "ios/chrome/browser/tabs/tab.h"
#import "ios/chrome/browser/ui/browser_view_controller.h"
#include "ios/chrome/browser/ui/tab_switcher/tab_switcher_transition_context.h"
@@ -22,10 +22,7 @@
@end
-@implementation TabSwitcherTransitionContextContent {
- base::mac::ObjCPropertyReleaser
- _propertyReleaser_tabSwitcherTransitionContextContent;
-}
+@implementation TabSwitcherTransitionContextContent
+ (instancetype)tabSwitcherTransitionContextContentFromBVC:
(BrowserViewController*)bvc {
@@ -64,21 +61,14 @@
@synthesize toolbarSnapshotView = _toolbarSnapshotView;
@synthesize initialSelectedTabIndex = _initialSelectedTabIndex;
-- (instancetype)init {
- self = [super init];
- if (self) {
- _propertyReleaser_tabSwitcherTransitionContextContent.Init(
- self, [TabSwitcherTransitionContextContent class]);
- }
- return self;
+- (void)dealloc {
+ base::mac::ReleaseProperties(self);
+ [super dealloc];
}
@end
-@implementation TabSwitcherTransitionContext {
- base::mac::ObjCPropertyReleaser
- _propertyReleaser_tabSwitcherTransitionContext;
-}
+@implementation TabSwitcherTransitionContext
+ (instancetype)
tabSwitcherTransitionContextWithCurrent:(BrowserViewController*)currentBVC
@@ -107,13 +97,9 @@ tabSwitcherTransitionContextWithCurrent:(BrowserViewController*)currentBVC
@synthesize regularContent = _regularContent;
@synthesize initialTabModel = _initialTabModel;
-- (instancetype)init {
- self = [super init];
- if (self) {
- _propertyReleaser_tabSwitcherTransitionContext.Init(
- self, [TabSwitcherTransitionContext class]);
- }
- return self;
+- (void)dealloc {
+ base::mac::ReleaseProperties(self);
+ [super dealloc];
}
@end

Powered by Google App Engine
This is Rietveld 408576698