Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Unified Diff: ios/chrome/browser/ui/tabs/tab_strip_controller.mm

Issue 2610923005: Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)
Patch Set: weak -> assign Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/tabs/tab_strip_controller.mm
diff --git a/ios/chrome/browser/ui/tabs/tab_strip_controller.mm b/ios/chrome/browser/ui/tabs/tab_strip_controller.mm
index ced59b8ddf92bb3c4f5b09453dda550999c6260b..dac8dafc8d095257d642eaed98b4d62a1a8cfcfa 100644
--- a/ios/chrome/browser/ui/tabs/tab_strip_controller.mm
+++ b/ios/chrome/browser/ui/tabs/tab_strip_controller.mm
@@ -12,7 +12,7 @@
#import "base/ios/weak_nsobject.h"
#include "base/mac/bundle_locations.h"
#include "base/mac/foundation_util.h"
-#include "base/mac/objc_property_releaser.h"
+#include "base/mac/objc_release_properties.h"
#include "base/mac/scoped_nsobject.h"
#include "base/metrics/user_metrics.h"
#include "base/metrics/user_metrics_action.h"
@@ -191,8 +191,6 @@ const CGFloat kNewTabButtonBottomOffsetHighRes = 2.0;
// If YES, display the tab switcher toggle switch at the left side of the
// strip. Can be set after creation.
BOOL _hasTabSwitcherToggleSwitch;
-
- base::mac::ObjCPropertyReleaser _propertyReleaser_TabStripController;
}
@property(nonatomic, readonly, retain) TabStripView* tabStripView;
@@ -339,7 +337,6 @@ const CGFloat kNewTabButtonBottomOffsetHighRes = 2.0;
- (instancetype)initWithTabModel:(TabModel*)tabModel
style:(TabStrip::Style)style {
if ((self = [super init])) {
- _propertyReleaser_TabStripController.Init(self, [TabStripController class]);
_tabArray.reset([[NSMutableArray alloc] initWithCapacity:10]);
_closingTabs.reset([[NSMutableSet alloc] initWithCapacity:5]);
@@ -445,6 +442,7 @@ const CGFloat kNewTabButtonBottomOffsetHighRes = 2.0;
[_tabStripView setDelegate:nil];
[_tabStripView setLayoutDelegate:nil];
[_tabModel removeObserver:self];
+ base::mac::ReleaseProperties(self);
[super dealloc];
}

Powered by Google App Engine
This is Rietveld 408576698