Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: ios/chrome/browser/ui/ntp/new_tab_page_view.h

Issue 2610923005: Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)
Patch Set: weak -> assign Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/ntp/new_tab_page_view.h
diff --git a/ios/chrome/browser/ui/ntp/new_tab_page_view.h b/ios/chrome/browser/ui/ntp/new_tab_page_view.h
index 9c38c4b52e7b2a115a8e17de5619cceb0035ff36..ce34387d8d50f5e235b4c7e1733716cc2cdef876 100644
--- a/ios/chrome/browser/ui/ntp/new_tab_page_view.h
+++ b/ios/chrome/browser/ui/ntp/new_tab_page_view.h
@@ -12,8 +12,8 @@
// Container view for the new tab page so that the subviews don't get directly
// accessed from the view controller.
@interface NewTabPageView : UIView
-@property(nonatomic, weak, readonly) UIScrollView* scrollView;
-@property(nonatomic, weak, readonly) NewTabPageBar* tabBar;
+@property(nonatomic, assign, readonly) UIScrollView* scrollView;
+@property(nonatomic, assign, readonly) NewTabPageBar* tabBar;
Sidney San Martín 2017/01/05 03:24:05 Is this change correct? The compiler won't synthes
noyau (Ping after 24h) 2017/01/05 10:02:52 I'm confused by your statement. There is an explic
noyau (Ping after 24h) 2017/01/06 14:21:06 Ok. for MRR assign is correct and weak is incorrec
- (instancetype)initWithFrame:(CGRect)frame
andScrollView:(UIScrollView*)scrollView

Powered by Google App Engine
This is Rietveld 408576698