Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: ios/chrome/browser/ui/stack_view/stack_view_controller.mm

Issue 2610923005: Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)
Patch Set: weak -> assign Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/stack_view/stack_view_controller.mm
diff --git a/ios/chrome/browser/ui/stack_view/stack_view_controller.mm b/ios/chrome/browser/ui/stack_view/stack_view_controller.mm
index 190b7ca8712633cfd5dc8a377afc152ba5fe7c24..cc425c7018974fe0f8c07d9bd1202e44fdd8d4f4 100644
--- a/ios/chrome/browser/ui/stack_view/stack_view_controller.mm
+++ b/ios/chrome/browser/ui/stack_view/stack_view_controller.mm
@@ -16,7 +16,7 @@
#include "base/logging.h"
#import "base/mac/bundle_locations.h"
#import "base/mac/foundation_util.h"
-#import "base/mac/objc_property_releaser.h"
+#include "base/mac/objc_release_properties.h"
#include "base/mac/scoped_block.h"
#import "base/mac/scoped_nsobject.h"
#include "base/metrics/histogram.h"
@@ -489,8 +489,6 @@ NSString* const kDummyToolbarBackgroundViewAnimationKey =
// |YES| if there is card set animation being processed. For testing only.
// Save last touch point used by new tab animation.
CGPoint _lastTapPoint;
-
- base::mac::ObjCPropertyReleaser _propertyReleaserStackViewController;
}
@synthesize activeCardSet = _activeCardSet;
@@ -513,8 +511,6 @@ NSString* const kDummyToolbarBackgroundViewAnimationKey =
DCHECK(activeCardSet == otrCardSet || activeCardSet == mainCardSet);
self = [super initWithNibName:nil bundle:nil];
if (self) {
- _propertyReleaserStackViewController.Init(self,
- [StackViewController class]);
[self setUpWithMainCardSet:mainCardSet
otrCardSet:otrCardSet
activeCardSet:activeCardSet];
@@ -816,6 +812,7 @@ NSString* const kDummyToolbarBackgroundViewAnimationKey =
[_mainCardSet setObserver:nil];
[_otrCardSet setObserver:nil];
[self cleanUpViewsAndNotifications];
+ base::mac::ReleaseProperties(self);
[super dealloc];
}

Powered by Google App Engine
This is Rietveld 408576698