Modify Copy{Sub}TextureCHROMIUM entry point to add level argument

Modify Copy{Sub}TextureCHROMIUM entry point to add level argument

This CL is just to add level argument and only allow level == 0
currently. Level > 0 support will be implemented in a separate CL.

BUG=612542
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2610853005
Cr-Commit-Position: refs/heads/master@{#442232}
Committed: https://chromium.googlesource.com/chromium/src/+/7ff451867f332a745a18fde712f091cb80e18548

[qiankun, 2017-01-05 06:08:00]

Description was changed from

==========
Modify Copy{Sub}TextureCHROMIUM entry point to add level argument

This CL is just to add level argument and only allow level == 0
currently. Level > 0 support will be implemented in a separate CL.

BUG=612542
==========

to

==========
Modify Copy{Sub}TextureCHROMIUM entry point to add level argument

This CL is just to add level argument and only allow level == 0
currently. Level > 0 support will be implemented in a separate CL.

BUG=612542
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[qiankun, 2017-01-05 06:08:01]

Description was changed from

==========
Modify Copy{Sub}TextureCHROMIUM entry point to add level argument

This CL is just to add level argument and only allow level == 0
currently. Level > 0 support will be implemented in a separate CL.

BUG=612542
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Modify Copy{Sub}TextureCHROMIUM entry point to add level argument

This CL is just to add level argument and only allow level == 0
currently. Level > 0 support will be implemented in a separate CL.

BUG=612542
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[qiankun, 2017-01-05 14:45:42]

Description was changed from

==========
Modify Copy{Sub}TextureCHROMIUM entry point to add level argument

This CL is just to add level argument and only allow level == 0
currently. Level > 0 support will be implemented in a separate CL.

BUG=612542
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Modify Copy{Sub}TextureCHROMIUM entry point to add level argument

This CL is just to add level argument and only allow level == 0
currently. Level > 0 support will be implemented in a separate CL.

BUG=612542
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[qiankun, 2017-01-05 14:45:43]

qiankun.miao@intel.com changed reviewers:
+ dalecurtis@chromium.org, danakj@chromium.org, kbr@chromium.org,
qinmin@chromium.org, yunchao.he@intel.com, zmo@chromium.org

[qiankun, 2017-01-05 14:49:07]

qiankun.miao@intel.com changed reviewers:
+ chcunningham@chromium.org, enne@chromium.org
- dalecurtis@chromium.org, danakj@chromium.org

[qiankun, 2017-01-05 14:57:27]

Preliminary work to support level > 0 for CopyTextureCHROMIUM extension. This CL
just adds level arguments to glCopyTextureCHROMIUM and glCopySubTextureCHROMIUM
and doesn't change behavior of chrome by limiting source_level == 0 and
dest_level == 0. The real implementation will be in a follow-up CL.

zmo: please review the whole CL.
kbr: owner review for third_party/WebKit/Source/platform/graphics/
enne: owner review for cc/
qinmin: owner review for content/renderer/media/android/
chcunningham: owner review for media/renderers/

[chcunningham, 2017-01-05 19:10:37]

chcunningham@chromium.org changed reviewers:
+ liberato@chromium.org
- chcunningham@chromium.org

[chcunningham, 2017-01-05 19:10:37]

+liberato@ for media (GL stuff)

[liberato (no reviews please), 2017-01-05 19:23:09]

On 2017/01/05 19:10:37, chcunningham wrote:
> +liberato@ for media (GL stuff)

media bits lgtm.

[Zhenyao Mo, 2017-01-05 21:30:14]

lgtm with nits

https://codereview.chromium.org/2610853005/diff/20001/gpu/GLES2/gl2extchromium.h
File gpu/GLES2/gl2extchromium.h (right):

https://codereview.chromium.org/2610853005/diff/20001/gpu/GLES2/gl2extchromiu...
gpu/GLES2/gl2extchromium.h:392: GLenum source_id,
You also need to update here.

https://codereview.chromium.org/2610853005/diff/20001/gpu/GLES2/gl2extchromiu...
gpu/GLES2/gl2extchromium.h:401: GLenum source_id,
and here.

[Ken Russell (switch to Gerrit), 2017-01-05 23:52:08]

third_party/WebKit/Source/platform/graphics/ LGTM.

[qinmin, 2017-01-06 22:09:46]

lgtm

[qiankun, 2017-01-09 08:05:39]

The CQ bit was checked by qiankun.miao@intel.com

[qiankun, 2017-01-09 08:05:40]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
zmo@chromium.org, qinmin@chromium.org, liberato@chromium.org
Link to the patchset: https://codereview.chromium.org/2610853005/#ps40001
(title: "rebase and fix nits")

[commit-bot: I haz the power, 2017-01-09 08:05:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 08:13:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 08:13:05]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[qiankun, 2017-01-09 08:16:26]

qiankun.miao@intel.com changed reviewers:
+ danakj@chromium.org, vmpstr@chromium.org

[qiankun, 2017-01-09 08:16:27]

enne, danakj, vmpstr, can you do owner review for cc/?

https://codereview.chromium.org/2610853005/diff/20001/gpu/GLES2/gl2extchromium.h
File gpu/GLES2/gl2extchromium.h (right):

https://codereview.chromium.org/2610853005/diff/20001/gpu/GLES2/gl2extchromiu...
gpu/GLES2/gl2extchromium.h:392: GLenum source_id,
On 2017/01/05 21:30:14, Zhenyao Mo wrote:
> You also need to update here.

Done.

https://codereview.chromium.org/2610853005/diff/20001/gpu/GLES2/gl2extchromiu...
gpu/GLES2/gl2extchromium.h:401: GLenum source_id,
On 2017/01/05 21:30:14, Zhenyao Mo wrote:
> and here.

Done.

[qiankun, 2017-01-09 08:57:34]

The CQ bit was checked by qiankun.miao@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 08:57:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[qiankun, 2017-01-09 10:13:23]

qiankun.miao@intel.com changed reviewers:
+ reveman@chromium.org

[qiankun, 2017-01-09 10:13:24]

reveman, can you do owner review for components/exo/?

[commit-bot: I haz the power, 2017-01-09 10:22:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 10:22:06]

Dry run: This issue passed the CQ dry run.

[reveman, 2017-01-09 11:11:36]

cc/ and components/exo/ lgtm

[qiankun, 2017-01-09 11:25:08]

The CQ bit was checked by qiankun.miao@intel.com

[qiankun, 2017-01-09 11:25:09]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
liberato@chromium.org, zmo@chromium.org, qinmin@chromium.org
Link to the patchset: https://codereview.chromium.org/2610853005/#ps60001
(title: "fix chromeos")

[commit-bot: I haz the power, 2017-01-09 11:25:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 11:29:28]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1483961108499260,
"parent_rev": "1afd533c0b1cc9243871660ff3b289990197d3fc", "commit_rev":
"7ff451867f332a745a18fde712f091cb80e18548"}

[commit-bot: I haz the power, 2017-01-09 11:29:55]

Description was changed from

==========
Modify Copy{Sub}TextureCHROMIUM entry point to add level argument

This CL is just to add level argument and only allow level == 0
currently. Level > 0 support will be implemented in a separate CL.

BUG=612542
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Modify Copy{Sub}TextureCHROMIUM entry point to add level argument

This CL is just to add level argument and only allow level == 0
currently. Level > 0 support will be implemented in a separate CL.

BUG=612542
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2610853005
Cr-Commit-Position: refs/heads/master@{#442232}
Committed:
https://chromium.googlesource.com/chromium/src/+/7ff451867f332a745a18fde712f0...
==========

[commit-bot: I haz the power, 2017-01-09 11:29:57]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/7ff451867f332a745a18fde712f0...