Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2610603002: gpu: Use the sh-scoped translator methods. (Closed)

Created:
3 years, 11 months ago by Jamie Madill
Modified:
3 years, 11 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Use the sh-scoped translator methods. The old ShCompile will be removed and replaced with sh::Compile in ANGLE to avoid conflicting with glslang's identically named methods. BUG=angleproject:1319 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/d16b21037855f558269ab8cb0b8bdf766e85a0d7 Cr-Commit-Position: refs/heads/master@{#441166}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -32 lines) Patch
M gpu/angle_unittest_main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/program_manager.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/shader_translator.cc View 12 chunks +18 lines, -19 lines 0 comments Download
M gpu/command_buffer/service/shader_translator_cache_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/shader_translator_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Jamie Madill
PTAL
3 years, 11 months ago (2017-01-02 22:55:24 UTC) #8
Zhenyao Mo
On 2017/01/02 22:55:24, Jamie Madill wrote: > PTAL lgtm
3 years, 11 months ago (2017-01-03 18:19:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2610603002/1
3 years, 11 months ago (2017-01-03 18:28:44 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-03 18:33:11 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 18:37:33 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d16b21037855f558269ab8cb0b8bdf766e85a0d7
Cr-Commit-Position: refs/heads/master@{#441166}

Powered by Google App Engine
This is Rietveld 408576698