Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 2610163004: Use StringView for String::split. (Closed)

Created:
3 years, 11 months ago by esprehn
Modified:
3 years, 11 months ago
CC:
blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use StringView for String::split. This avoids allocating temporary strings when splitting. All existing callers use literal strings anyway. BUG=615174 Committed: https://crrev.com/0125df43361259da6152b2507d62fb008c9a5d46 Cr-Commit-Position: refs/heads/master@{#441519}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/Source/wtf/text/WTFString.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/WTFString.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (10 generated)
esprehn
3 years, 11 months ago (2017-01-04 22:03:14 UTC) #3
dglazkov
lgtm
3 years, 11 months ago (2017-01-04 23:47:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2610163004/1
3 years, 11 months ago (2017-01-04 23:48:22 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-04 23:53:08 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0125df43361259da6152b2507d62fb008c9a5d46 Cr-Commit-Position: refs/heads/master@{#441519}
3 years, 11 months ago (2017-01-04 23:56:33 UTC) #15
Charlie Harrison
3 years, 11 months ago (2017-01-05 00:12:48 UTC) #16
Message was sent while issue was closed.
lgtm/2!

Powered by Google App Engine
This is Rietveld 408576698