Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1310)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/wtf/text/WTFString.h

Issue 2610163004: Use StringView for String::split. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/wtf/text/WTFString.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/wtf/text/WTFString.h
diff --git a/third_party/WebKit/Source/wtf/text/WTFString.h b/third_party/WebKit/Source/wtf/text/WTFString.h
index d0382a01426a3d036922e3de9007f1b03c5e6b0a..b04d49f410594b0fe05fa0af75febd603b181e0b 100644
--- a/third_party/WebKit/Source/wtf/text/WTFString.h
+++ b/third_party/WebKit/Source/wtf/text/WTFString.h
@@ -315,10 +315,10 @@ class WTF_EXPORT String {
return StringImpl::createUninitialized(length, data);
}
- void split(const String& separator,
+ void split(const StringView& separator,
bool allowEmptyEntries,
Vector<String>& result) const;
- void split(const String& separator, Vector<String>& result) const {
+ void split(const StringView& separator, Vector<String>& result) const {
split(separator, false, result);
}
void split(UChar separator,
« no previous file with comments | « no previous file | third_party/WebKit/Source/wtf/text/WTFString.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698