third_party/WebKit/Source/wtf/text/WTFString.cpp - Issue 2610163004: Use StringView for String::split.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/text/WTFString.cpp

Issue 2610163004: Use StringView for String::split. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/text/WTFString.cpp

diff --git a/third_party/WebKit/Source/wtf/text/WTFString.cpp b/third_party/WebKit/Source/wtf/text/WTFString.cpp

index 5e4f19cfeaf06a65b5c04d372fd93e5c9f4ce824..6fdc7d8f1d05d0a4512ee8fb315f8fd1fbd51631 100644

--- a/third_party/WebKit/Source/wtf/text/WTFString.cpp

+++ b/third_party/WebKit/Source/wtf/text/WTFString.cpp

@@ -496,7 +496,7 @@ bool String::isSafeToSendToAnotherThread() const {

return !m_impl || m_impl->isSafeToSendToAnotherThread();

}

-void String::split(const String& separator,

+void String::split(const StringView& separator,

bool allowEmptyEntries,

Vector<String>& result) const {

result.clear();

« no previous file with comments | « third_party/WebKit/Source/wtf/text/WTFString.h ('k') | no next file » | no next file with comments »