Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: chrome/browser/autofill/form_structure_browsertest.cc

Issue 2609703002: Remove ScopedVector from autofill. (Closed)
Patch Set: drop the using Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/autofill/content/renderer/form_autofill_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autofill/form_structure_browsertest.cc
diff --git a/chrome/browser/autofill/form_structure_browsertest.cc b/chrome/browser/autofill/form_structure_browsertest.cc
index 4a77401161403f5e33acc874517d54383d39a80b..3ee85ae5fced4ad050b5a466b88361a1682834d9 100644
--- a/chrome/browser/autofill/form_structure_browsertest.cc
+++ b/chrome/browser/autofill/form_structure_browsertest.cc
@@ -74,7 +74,7 @@ const std::vector<base::FilePath> GetTestFiles() {
// A data-driven test for verifying Autofill heuristics. Each input is an HTML
// file that contains one or more forms. The corresponding output file lists the
-// heuristically detected type for eachfield.
+// heuristically detected type for each field.
class FormStructureBrowserTest
: public InProcessBrowserTest,
public DataDrivenTest,
@@ -130,7 +130,7 @@ std::string FormStructureBrowserTest::FormStructuresToString(
const std::vector<std::unique_ptr<FormStructure>>& forms) {
std::string forms_string;
for (const auto& form : forms) {
- for (const AutofillField* field : *form) {
+ for (const auto& field : *form) {
forms_string += field->Type().ToString();
forms_string += " | " + base::UTF16ToUTF8(field->name);
forms_string += " | " + base::UTF16ToUTF8(field->label);
« no previous file with comments | « no previous file | components/autofill/content/renderer/form_autofill_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698