Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: components/password_manager/core/browser/password_form_manager_unittest.cc

Issue 2609703002: Remove ScopedVector from autofill. (Closed)
Patch Set: drop the using Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_form_manager_unittest.cc
diff --git a/components/password_manager/core/browser/password_form_manager_unittest.cc b/components/password_manager/core/browser/password_form_manager_unittest.cc
index b86d9f0434cd03d9ca251c9b3f03d294173d6d8f..cf390253c5a31e9f7786c42689682b8544ce2253 100644
--- a/components/password_manager/core/browser/password_form_manager_unittest.cc
+++ b/components/password_manager/core/browser/password_form_manager_unittest.cc
@@ -114,7 +114,7 @@ MATCHER_P2(CheckUploadedAutofillTypesAndSignature,
// An unexpected form is uploaded.
return false;
}
- for (const autofill::AutofillField* field : arg) {
+ for (const auto& field : arg) {
if (expected_types.find(field->name) == expected_types.end()) {
if (!field->possible_types().empty()) {
// Unexpected types are uploaded.
@@ -153,7 +153,7 @@ MATCHER_P2(CheckUploadedGenerationTypesAndSignature,
<< ", but found " << arg.FormSignatureAsStr();
return false;
}
- for (const autofill::AutofillField* field : arg) {
+ for (const auto& field : arg) {
if (expected_generation_types.find(field->name) ==
expected_generation_types.end()) {
if (field->generation_type() !=
@@ -183,7 +183,7 @@ MATCHER_P2(CheckUploadedFormClassifierVote,
found_generation_element,
generation_element,
"Wrong form classifier votes") {
- for (const autofill::AutofillField* field : arg) {
+ for (const auto& field : arg) {
if (found_generation_element && field->name == generation_element) {
EXPECT_EQ(field->form_classifier_outcome(),
autofill::AutofillUploadContents::Field::GENERATION_ELEMENT);
@@ -199,7 +199,7 @@ MATCHER_P2(CheckUploadedFormClassifierVote,
MATCHER_P(CheckFieldPropertiesMasksUpload,
expected_field_properties,
"Wrong field properties flags") {
- for (const autofill::AutofillField* field : arg) {
+ for (const auto& field : arg) {
autofill::FieldPropertiesMask expected_mask =
expected_field_properties.find(field->name) !=
expected_field_properties.end()

Powered by Google App Engine
This is Rietveld 408576698