Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2609573002: Revert "DevTools: remove invalidateSize from Widget, make show/hideWidget receive no params." (Closed)

Created:
3 years, 11 months ago by caseq
Modified:
3 years, 11 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org, ahmetemirercin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "DevTools: remove invalidateSize from Widget, make show/hideWidget receive no params." This reverts commit 8ac28391aa13c48a46d1c35bf36e15b1e3c32452. BUG=676760 Committed: https://crrev.com/73f2c09f8eac33557842e72ff6c9d1a2213672fb Cr-Commit-Position: refs/heads/master@{#440991}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -46 lines) Patch
M third_party/WebKit/LayoutTests/inspector/components/widget-events.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js View 1 chunk +3 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js View 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Widget.js View 6 chunks +18 lines, -30 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
caseq
This is a manual revert of https://codereview.chromium.org/2570633004 that factors in the changes from https://codereview.chromium.org/2595743002 that ...
3 years, 11 months ago (2016-12-29 20:01:02 UTC) #2
dgozman
rs lgtm
3 years, 11 months ago (2016-12-29 20:05:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2609573002/1
3 years, 11 months ago (2016-12-29 20:07:40 UTC) #5
caseq
3 years, 11 months ago (2016-12-29 20:09:58 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2016-12-29 22:06:32 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:53:20 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/73f2c09f8eac33557842e72ff6c9d1a2213672fb
Cr-Commit-Position: refs/heads/master@{#440991}

Powered by Google App Engine
This is Rietveld 408576698