DevTools: remove invalidateSize from Widget, make show/hideWidget receive no params.

DevTools: remove invalidateSize from Widget, make show/hideWidget receive no params.

Committed: https://crrev.com/8ac28391aa13c48a46d1c35bf36e15b1e3c32452
Cr-Commit-Position: refs/heads/master@{#438416}

[pfeldman, 2016-12-13 22:56:27]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org, einbinder@chromium.org

[pfeldman, 2016-12-13 22:58:15]

pfeldman@chromium.org changed reviewers:
+ caseq@chromium.org

[caseq, 2016-12-14 01:29:26]

https://codereview.chromium.org/2570633004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui/Widget.js (right):

https://codereview.chromium.org/2570633004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/Widget.js:275:
attach(parentWidget, parentElement, insertBefore) {
Let's avoid exposing this to the public interface, it doesn't look like we ever
attach to a non-default parent or insertion point.

https://codereview.chromium.org/2570633004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/Widget.js:278:
this._attachedBeforeElement = insertBefore;
s/Element/Node?

https://codereview.chromium.org/2570633004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/Widget.js:295: var insertBefore
= this._attachedBeforeElement;
Add a check that the element is not gone?

[pfeldman, 2016-12-14 01:38:40]

https://codereview.chromium.org/2570633004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui/Widget.js (right):

https://codereview.chromium.org/2570633004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/Widget.js:275:
attach(parentWidget, parentElement, insertBefore) {
On 2016/12/14 01:29:26, caseq wrote:
> Let's avoid exposing this to the public interface, it doesn't look like we
ever
> attach to a non-default parent or insertion point.

Done.

https://codereview.chromium.org/2570633004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/Widget.js:278:
this._attachedBeforeElement = insertBefore;
On 2016/12/14 01:29:25, caseq wrote:
> s/Element/Node?

Done.

https://codereview.chromium.org/2570633004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/Widget.js:295: var insertBefore
= this._attachedBeforeElement;
On 2016/12/14 01:29:26, caseq wrote:
> Add a check that the element is not gone?

Browser would throw if something like that happens.

[caseq, 2016-12-14 01:45:49]

lgtm

[pfeldman, 2016-12-14 01:48:33]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2016-12-14 01:49:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 03:38:12]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481680113820650,
"parent_rev": "f14628a81dcf8449eac69a83cd679e2e5350f349", "commit_rev":
"a5ffc274e746798a7ff984b8ef6127536c9508c6"}

[commit-bot: I haz the power, 2016-12-14 03:38:40]

Description was changed from

==========
DevTools: remove invalidateSize from Widget, make show/hideWidget receive no
params.
==========

to

==========
DevTools: remove invalidateSize from Widget, make show/hideWidget receive no
params.

Review-Url: https://codereview.chromium.org/2570633004
==========

[commit-bot: I haz the power, 2016-12-14 03:38:41]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-14 03:41:02]

Description was changed from

==========
DevTools: remove invalidateSize from Widget, make show/hideWidget receive no
params.

Review-Url: https://codereview.chromium.org/2570633004
==========

to

==========
DevTools: remove invalidateSize from Widget, make show/hideWidget receive no
params.

Committed: https://crrev.com/8ac28391aa13c48a46d1c35bf36e15b1e3c32452
Cr-Commit-Position: refs/heads/master@{#438416}
==========

[commit-bot: I haz the power, 2016-12-14 03:41:03]

Patchset 3 (id:??) landed as
https://crrev.com/8ac28391aa13c48a46d1c35bf36e15b1e3c32452
Cr-Commit-Position: refs/heads/master@{#438416}