Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2595743002: DevTools: refactor filter bar to highlight it in red when non-default filters are installed. (Closed)

Created:
3 years, 12 months ago by pfeldman
Modified:
3 years, 12 months ago
Reviewers:
dgozman, pfeldman1
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: refactor filter bar to highlight it in red when non-default filters are installed. Committed: https://crrev.com/a32731170c22b450550b93299657a3af9b434d2d Cr-Commit-Position: refs/heads/master@{#440064}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -51 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js View 4 chunks +18 lines, -51 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
pfeldman
3 years, 12 months ago (2016-12-21 00:21:02 UTC) #2
dgozman
lgtm
3 years, 12 months ago (2016-12-21 00:35:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2595743002/1
3 years, 12 months ago (2016-12-21 08:47:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 12 months ago (2016-12-21 10:03:58 UTC) #8
commit-bot: I haz the power
3 years, 12 months ago (2016-12-21 10:06:06 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a32731170c22b450550b93299657a3af9b434d2d
Cr-Commit-Position: refs/heads/master@{#440064}

Powered by Google App Engine
This is Rietveld 408576698