[Reland] Maintain HostZoom connection per-frame on browser side

[Reland] Maintain HostZoom connection per-frame on browser side

This CL is a reland of https://codereview.chromium.org/2581143002.
That CL was reverted due to a failing layouttest. Investigation revealed
that the layouttest itself was busted, and that test has now been
removed (see the discussion on crbug.com/673065 for details).

Original CL description:

HostZoomMapObserver is a per-WebContents class, while the HostZoom Mojo
connection is per-frame. Before this CL, HostZoomMapObserver was
maintaining one HostZoom connection and rebinding it every time a new
RenderFrame was created. This meant that HostZoomMapObserver was
continually losing connections to existing frames. This CL changes
HostZoomMapObserver to maintain one connection per-RenderFrame in a
map indexed by the corresponding RenderFrameHost.

BUG=673065
TEST=Visit news.ycombinator.com and increase the zoom level to 175%.
Click the top link. Hit back: news.ycombinator.com should still be
zoomed to 175%.

TBR=jochen

Review-Url: https://codereview.chromium.org/2609003004
Cr-Commit-Position: refs/heads/master@{#441629}
Committed: https://chromium.googlesource.com/chromium/src/+/e7aa3298381a03045a4a6dc6379990275dbfb247

[blundell, 2017-01-03 11:01:33]

The CQ bit was checked by blundell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 11:01:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 12:29:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 12:29:40]

Dry run: This issue passed the CQ dry run.

[blundell, 2017-01-03 12:55:33]

blundell@chromium.org changed reviewers:
+ wjmaclean@chromium.org

[wjmaclean, 2017-01-03 19:49:38]

On 2017/01/03 12:55:34, blundell wrote:

lgtm, to land after the offending layout test is gone.

[blundell, 2017-01-05 10:59:28]

Description was changed from

==========
[Reland] Maintain HostZoom connection per-frame on browser side

This CL is a reland of https://codereview.chromium.org/2581143002.
That CL was reverted due to a failing layouttest. Investigation revealed
that the layouttest itself was busted, and that test has now been
removed (see the discussion on crbug.com/673065 for details).

Original CL description:

HostZoomMapObserver is a per-WebContents class, while the HostZoom Mojo
connection is per-frame. Before this CL, HostZoomMapObserver was
maintaining one HostZoom connection and rebinding it every time a new
RenderFrame was created. This meant that HostZoomMapObserver was
continually losing connections to existing frames. This CL changes
HostZoomMapObserver to maintain one connection per-RenderFrame in a
map indexed by the corresponding RenderFrameHost.

BUG=673065
TEST=Visit news.ycombinator.com and increase the zoom level to 175%.
Click the top link. Hit back: news.ycombinator.com should still be
zoomed to 175%.
==========

to

==========
[Reland] Maintain HostZoom connection per-frame on browser side

This CL is a reland of https://codereview.chromium.org/2581143002.
That CL was reverted due to a failing layouttest. Investigation revealed
that the layouttest itself was busted, and that test has now been
removed (see the discussion on crbug.com/673065 for details).

Original CL description:

HostZoomMapObserver is a per-WebContents class, while the HostZoom Mojo
connection is per-frame. Before this CL, HostZoomMapObserver was
maintaining one HostZoom connection and rebinding it every time a new
RenderFrame was created. This meant that HostZoomMapObserver was
continually losing connections to existing frames. This CL changes
HostZoomMapObserver to maintain one connection per-RenderFrame in a
map indexed by the corresponding RenderFrameHost.

BUG=673065
TEST=Visit news.ycombinator.com and increase the zoom level to 175%.
Click the top link. Hit back: news.ycombinator.com should still be
zoomed to 175%.

TBR=jochen
==========

[blundell, 2017-01-05 10:59:28]

blundell@chromium.org changed reviewers:
+ jochen@chromium.org

[blundell, 2017-01-05 10:59:51]

TBR=jochen for //content/browser/zoom_browsertest.cc as this is an unchanged
reland of an earlier CL

[blundell, 2017-01-05 10:59:57]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2017-01-05 11:00:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2017-01-05 12:00:49]

lgtm

[commit-bot: I haz the power, 2017-01-05 12:38:59]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483613997792560, "parent_rev":
"c2d4ad838a7a80e4dbae71f7fbf7fb720cc78706", "commit_rev":
"e7aa3298381a03045a4a6dc6379990275dbfb247"}

[commit-bot: I haz the power, 2017-01-05 12:39:26]

Description was changed from

==========
[Reland] Maintain HostZoom connection per-frame on browser side

This CL is a reland of https://codereview.chromium.org/2581143002.
That CL was reverted due to a failing layouttest. Investigation revealed
that the layouttest itself was busted, and that test has now been
removed (see the discussion on crbug.com/673065 for details).

Original CL description:

HostZoomMapObserver is a per-WebContents class, while the HostZoom Mojo
connection is per-frame. Before this CL, HostZoomMapObserver was
maintaining one HostZoom connection and rebinding it every time a new
RenderFrame was created. This meant that HostZoomMapObserver was
continually losing connections to existing frames. This CL changes
HostZoomMapObserver to maintain one connection per-RenderFrame in a
map indexed by the corresponding RenderFrameHost.

BUG=673065
TEST=Visit news.ycombinator.com and increase the zoom level to 175%.
Click the top link. Hit back: news.ycombinator.com should still be
zoomed to 175%.

TBR=jochen
==========

to

==========
[Reland] Maintain HostZoom connection per-frame on browser side

This CL is a reland of https://codereview.chromium.org/2581143002.
That CL was reverted due to a failing layouttest. Investigation revealed
that the layouttest itself was busted, and that test has now been
removed (see the discussion on crbug.com/673065 for details).

Original CL description:

HostZoomMapObserver is a per-WebContents class, while the HostZoom Mojo
connection is per-frame. Before this CL, HostZoomMapObserver was
maintaining one HostZoom connection and rebinding it every time a new
RenderFrame was created. This meant that HostZoomMapObserver was
continually losing connections to existing frames. This CL changes
HostZoomMapObserver to maintain one connection per-RenderFrame in a
map indexed by the corresponding RenderFrameHost.

BUG=673065
TEST=Visit news.ycombinator.com and increase the zoom level to 175%.
Click the top link. Hit back: news.ycombinator.com should still be
zoomed to 175%.

TBR=jochen

Review-Url: https://codereview.chromium.org/2609003004
Cr-Commit-Position: refs/heads/master@{#441629}
Committed:
https://chromium.googlesource.com/chromium/src/+/e7aa3298381a03045a4a6dc63799...
==========

[commit-bot: I haz the power, 2017-01-05 12:39:26]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e7aa3298381a03045a4a6dc63799...