Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issue 2611573004: Remove dead ViewMsg_{Zoom, DidZoomUrl} (Closed)

Created:
3 years, 11 months ago by blundell
Modified:
3 years, 11 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dead ViewMsg_{Zoom, DidZoomUrl} These messages and surrounding infra seem to be left over from prior implementations of various pieces of zoom functionality (e.g., zooming in plugins). The code being removed is never exercised: - The browser-side entrypoint for sending ViewMsg_Zoom is RenderViewHost::Zoom(), which is never called. - The renderer-side entrypoint for sending ViewMsg_DidZoomUrl is RenderViewImpl::zoomLevelChanged(), which is never called. I noticed this while investigating crbug.com/673065. BUG=673065 Review-Url: https://codereview.chromium.org/2611573004 Cr-Commit-Position: refs/heads/master@{#441679} Committed: https://chromium.googlesource.com/chromium/src/+/dbe99b00fc1b41191214bb2c68c7f8b0b11487bd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -83 lines) Patch
M content/browser/renderer_host/render_view_host_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 3 chunks +0 lines, -16 lines 0 comments Download
M content/common/view_messages.h View 2 chunks +0 lines, -14 lines 0 comments Download
M content/public/browser/render_view_host.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/render_view_impl.h View 3 chunks +1 line, -4 lines 0 comments Download
M content/renderer/render_view_impl.cc View 3 chunks +0 lines, -45 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 19 (11 generated)
blundell
3 years, 11 months ago (2017-01-03 13:31:33 UTC) #7
wjmaclean
On 2017/01/03 13:31:33, blundell wrote: I think this should be ok ... lgtm.
3 years, 11 months ago (2017-01-03 19:48:15 UTC) #8
blundell
+jochen for //content OWNERS
3 years, 11 months ago (2017-01-05 14:08:04 UTC) #10
blundell
+dcheng for view_messages.h
3 years, 11 months ago (2017-01-05 14:08:35 UTC) #12
jochen (gone - plz use gerrit)
lgtm
3 years, 11 months ago (2017-01-05 14:16:07 UTC) #13
dcheng
lgtm
3 years, 11 months ago (2017-01-05 16:14:28 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2611573004/1
3 years, 11 months ago (2017-01-05 16:16:26 UTC) #16
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 17:15:57 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dbe99b00fc1b41191214bb2c68c7...

Powered by Google App Engine
This is Rietveld 408576698