Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 2612543002: Remove fundamentally-broken layouttest for zoom on reload (Closed)

Created:
3 years, 11 months ago by blundell
Modified:
3 years, 11 months ago
Reviewers:
wjmaclean
CC:
chromium-reviews, blink-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove fundamentally-broken layouttest for zoom on reload The test being preserved is attempting to test that zoom is preserved on reload. However, the mechanism used to do the zoom is renderer-side rather than browser-side. This mechanism (a) doesn't reflect reality and (b) means that the browser is not informed of the initial zoom, making the test fundamentally broken. It is passing on the tree due to a combination of other bugs (see the discussion on crbug.com/673065 for details). This CL removes the test. It has been replaced by a browsertest that exercises this functionality in a manner reflecting real-world usage. BUG=673065 Committed: https://crrev.com/8872b06af376de3ebc7e96aec1fcbe68dae5d27a Cr-Commit-Position: refs/heads/master@{#441617}

Patch Set 1 #

Messages

Total messages: 16 (11 generated)
blundell
3 years, 11 months ago (2017-01-03 12:55:04 UTC) #6
wjmaclean
On 2017/01/03 12:55:04, blundell wrote: lgtm
3 years, 11 months ago (2017-01-03 16:24:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2612543002/1
3 years, 11 months ago (2017-01-05 08:19:04 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-05 10:36:11 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 10:38:50 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8872b06af376de3ebc7e96aec1fcbe68dae5d27a
Cr-Commit-Position: refs/heads/master@{#441617}

Powered by Google App Engine
This is Rietveld 408576698