Fix RGBA alpha parsing and serialization to adhere to W3 standard.

Fix RGBA alpha parsing and serialization to adhere to W3 standard.

Specifically, a 2.55 multiplication factor should be used, and
serialization should be to two or three digits according to section
<alphavalue> in https://drafts.csswg.org/cssom/#serializing-css-values

This fixes test case "background-color: rgba(5, 7, 10, 0.5)" in
https://w3c-test.org/cssom/serialize-values.html and also that the
implementation is now same as Firefox as noted in the bug.

Note a large number of tests need to be fixed, many of them because:
- *-expected.txt specifically had bad alpha values such as 0.501961 or
- an alpha value of 0.5 was previously 127 but should have been 128.
The latter applies to the updated expected images too where the only
difference was tiny bit of alpha (and rgb when alpha blended) change.

BUG=453414
Review-Url: https://codereview.chromium.org/2608423002
Cr-Commit-Position: refs/heads/master@{#443157}
Committed: https://chromium.googlesource.com/chromium/src/+/13a86c2faeebcbc12dd4a7e8dea54318da635c19

[ktyliu, 2017-01-04 03:35:34]

Description was changed from

==========
Fix RGBA alpha parsing and serialization to adhere to W3 standard.

Specifically, a 2.55 multiplication factor should be used, and
serialization should be to two or three digits according to section
<alphavalue> in https://drafts.csswg.org/cssom/#serializing-css-values

This fixes test case "background-color: rgba(5, 7, 10, 0.5)" in
https://w3c-test.org/cssom/serialize-values.html

Note a large number of tests need to be fixed, many of them are because
an alpha value of 0.5 was previously 127 but should have been 128.
This applies to the changed expected images too where the difference is
only the most tiny bit of alpha (and rgb when alpha blended).

BUG=453414
==========

to

==========
Fix RGBA alpha parsing and serialization to adhere to W3 standard.

Specifically, a 2.55 multiplication factor should be used, and
serialization should be to two or three digits according to section
<alphavalue> in https://drafts.csswg.org/cssom/#serializing-css-values

This fixes test case "background-color: rgba(5, 7, 10, 0.5)" in
https://w3c-test.org/cssom/serialize-values.html

Note a large number of tests need to be fixed, many of them because:
- *-expected.txt specifically had bad alpha values such as 0.501961 or
- an alpha value of 0.5 was previously 127 but should have been 128.
The latter applies to the updated expected images too where the only
difference was tiny bit of alpha (and rgb when alpha blended) change.

BUG=453414
==========

[ktyliu, 2017-01-04 04:14:04]

The CQ bit was checked by ktyliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 04:14:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 06:20:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 06:20:06]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ktyliu, 2017-01-04 21:44:08]

The CQ bit was checked by ktyliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 21:44:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 23:43:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 23:43:50]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ktyliu, 2017-01-04 23:48:48]

ktyliu@chromium.org changed reviewers:
+ sashab@chromium.org

[ktyliu, 2017-01-04 23:48:51]

Hi Sasha,

I figured out why it's under @google.com and not @chromium.org -- I didn't run
"depot-tools-auth login https://codereview.chromium.org" after acquiring the
chromium.org account.

Hope it's fine that I start a new review under @chromium.org account. Previously
it was https://codereview.chromium.org/2606143002/
 
Also found it's not too difficult to update layout tests so I've modified them
here using `webkit-patch rebaseline-cl`.

Please let me know if this is okay.

Thanks,
Kevin

[sashab, 2017-01-05 00:18:21]

The way we rebaseline patches (because they need rebaselining on multiple
machines) is by editing the third_party/WebKit/LayoutTests/TestExpectations file
to add the tests with "NeedsRebaseline" as their value. See:
https://cs.chromium.org/chromium/infra/recipes/recipes/rebaseline_o_matic.py?...

Also I'm hesitant to land a patch that changes both code and tests, since its
unclear if the tests are breaking. What I'd rather do is:

1) Land a patch that changes the test inputs and rebaselines the tests, adding
tests that fail to show the bug
2) Land a patch that fixes the tests and fixes the failing tests

Does that make sense?

S

[Timothy Loh, 2017-01-05 03:29:36]

On 2017/01/05 00:18:21, sashab wrote:
> The way we rebaseline patches (because they need rebaselining on multiple
> machines) is by editing the third_party/WebKit/LayoutTests/TestExpectations
file
> to add the tests with "NeedsRebaseline" as their value. See:
>
https://cs.chromium.org/chromium/infra/recipes/recipes/rebaseline_o_matic.py?...
> 
> Also I'm hesitant to land a patch that changes both code and tests, since its
> unclear if the tests are breaking. What I'd rather do is:
> 
> 1) Land a patch that changes the test inputs and rebaselines the tests, adding
> tests that fail to show the bug
> 2) Land a patch that fixes the tests and fixes the failing tests
> 
> Does that make sense?
> 
> S

This change is rebaselining in the recommended way.
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/layout_t...

I'm not sure I understand the concern with changing the tests and code at the
same time (this is not really any different to adding tests and code at the same
time), could you clarify what you're worried about?

[sashab, 2017-01-05 03:42:43]

Sorry -- this was clarified in person.

It's unclear to me that this patch is working correctly because by changing both
the test and the expectations the original tests have been removed. So there
could be a bug hiding that was exposed by one of the tests but is no longer
exposed because that test has been changed. I'd much rather the tests were
changed separately to the code so its clear which tests are breaking and how
this bug fixes them.

From the doc you linked:
"This way, the new baselines can be reviewed along with the changes, which helps
the reviewer verify that the new baselines are correct. It also means that there
is no period of time when the layout test results are ignored."

This makes sense when there are a small number of tests, but this bloats the
review and makes it unlikely the patch will land safely (the tests could
conflict or produce different results while landing). I'd be much more confident
using the bot when there are this many tests that need rebaselining. That way
the review is also more meaningful, e.g. the changes to TestExpectations can be
looked at at a glance and followed through both CLs.

[alancutter (OOO until 2018), 2017-01-05 03:53:36]

All test modifications in this patch appear to be updating expectations, I don't
see any that are altering what the test is doing.

We get to see the effects of the code change in the patch that makes the code
change, if anything this is more suitable for reviewers.

[sashab, 2017-01-05 03:56:01]

sashab@chromium.org changed reviewers:
+ bugsnash@chromium.org

[sashab, 2017-01-05 03:56:02]

+bugsnash

OK, I'm convinced.

Kevin -- sorry for the misdirection. If you could add one more test that is
specifically for your bug (fails without your fix), and add it to this patch,
I'd be satisfied that your fix is working as intended.

[sashab, 2017-01-05 04:10:34]

Actual patch looks good, left some feedback on your test. I can't actually
review the rest of the expectations files so I'm happy to wait to see the
trybots confirm they are correct. If your test passes and failed before I'm
confident these are OK test changes.

Would also be great to know what firefox does and if this is a problem for them
too. If we were different to firefox but we're now the same that's an interop
bug fix which is great. But if we now have different behavior it needs further
justification.

https://codereview.chromium.org/2608423002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/css-parser/serialize-css-alpha-value.html
(right):

https://codereview.chromium.org/2608423002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/css-parser/serialize-css-alpha-value.html:2:
<title>Harness Test: Floating point alpha values of numbers to two decimial
places are serialized and returned correctly.</title>
Typo: decimal

https://codereview.chromium.org/2608423002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/css-parser/serialize-css-alpha-value.html:8: for
(var i = 0.0; i <= 1.0; i += 0.01) {
Maybe make it clearer that this used to fail for certain values, so this test is
for values like 0.1, 0.3, etc, the 0.01 is arbitrary but covers these failing
values and others

https://codereview.chromium.org/2608423002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/css-parser/serialize-css-alpha-value.html:14: });
Please add a title for this test - you can remove the <title> tag and put it
here instead

https://codereview.chromium.org/2608423002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/css-parser/serialize-css-alpha-value.html:14: });
Please add a title for this test - you can remove the <title> tag and put it
here instead

[ktyliu, 2017-01-05 05:51:55]

The CQ bit was checked by ktyliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 05:52:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 07:53:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 07:53:34]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ktyliu, 2017-01-05 21:51:54]

The CQ bit was checked by ktyliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 21:52:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 23:48:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 23:48:54]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ktyliu, 2017-01-06 01:05:53]

The CQ bit was checked by ktyliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 01:07:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ktyliu, 2017-01-06 01:58:30]

Thanks for the comments, Sasha.

I've checked that Firefox renders
http://software.hixie.ch/utilities/js/live-dom-viewer/?saved=3436 the same as
content_shell with this change --
https://screenshot.googleplex.com/UKmsiP8q4UE

Hope that git-cl try now passes. Looks like this is not really a GoodFirstBug
with so many layout tests requiring update :(

https://codereview.chromium.org/2608423002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/css-parser/serialize-css-alpha-value.html
(right):

https://codereview.chromium.org/2608423002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/css-parser/serialize-css-alpha-value.html:2:
<title>Harness Test: Floating point alpha values of numbers to two decimial
places are serialized and returned correctly.</title>
On 2017/01/05 04:10:34, sashab wrote:
> Typo: decimal

Done.

https://codereview.chromium.org/2608423002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/css-parser/serialize-css-alpha-value.html:8: for
(var i = 0.0; i <= 1.0; i += 0.01) {
actually almost all values would fail previously, as evident by going to
http://software.hixie.ch/utilities/js/live-dom-viewer/?saved=3436 on Chrome and
compare it with Firefox

added test description to clarify it tests correct parsing and serialization of
alpha with 2 decimals

https://codereview.chromium.org/2608423002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/css-parser/serialize-css-alpha-value.html:14: });
On 2017/01/05 04:10:34, sashab wrote:
> Please add a title for this test - you can remove the <title> tag and put it
> here instead

Acknowledged.

https://codereview.chromium.org/2608423002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/css-parser/serialize-css-alpha-value.html:14: });
I thought we should use <title> for a single test case, which Bugs thought so
too.
Anyway, I've now added another test case to spot test a few three decimals, and
made <title> describe the generic test context

Hope that's okay

[alancutter (OOO until 2018), 2017-01-06 02:46:57]

alancutter@chromium.org changed reviewers:
+ alancutter@chromium.org

[alancutter (OOO until 2018), 2017-01-06 02:47:00]

https://codereview.chromium.org/2608423002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/css-parser/serialize-css-alpha-value.html
(right):

https://codereview.chromium.org/2608423002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/css-parser/serialize-css-alpha-value.html:14: });
On 2017/01/06 at 01:58:30, ktyliu wrote:
> I thought we should use <title> for a single test case, which Bugs thought so
too.

Calls to test() should come with a description parameter as it's what shows up
in the test output, <title> will not appear.

[sashab, 2017-01-06 02:56:17]

https://codereview.chromium.org/2608423002/diff/80001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/css-parser/serialize-css-alpha-value.html
(right):

https://codereview.chromium.org/2608423002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/css-parser/serialize-css-alpha-value.html:2:
<title>Floating point alpha value parssing and serialization</title>
Do we have lots of other layout tests like this? Generally the format I've seen
in tests is like:

<!DOCTYPE html>
<script src=... testharness includes>
<script>
{ test goes here }
</script>

I'm happy to leave it if you think it's self-documenting, but just not sure if
other tests have it, and as alancutter@ said it won't be seen on test failure
(only the test title parameter will).

https://codereview.chromium.org/2608423002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/css-parser/serialize-css-alpha-value.html:14: },
'Alpha values with two decimals should parse and serialize to the same value');
How about, "Alpha values should parse and serialize to the same value to 2
decimal places"

https://codereview.chromium.org/2608423002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/css-parser/serialize-css-alpha-value.html:30: },
'Expected alpha values with three decimals');
"Alpha values with three decimals should parse and sometimes round up to the
same value" (would be great if you could clarify the 'sometimes')

[sashab, 2017-01-06 02:56:56]

And please add the notes on Firefox performing the same way to the bug. Also if
it's not there already, add the label Hotlist-Interop (interop bug).

[commit-bot: I haz the power, 2017-01-06 03:45:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 03:45:22]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ktyliu, 2017-01-08 21:33:55]

Description was changed from

==========
Fix RGBA alpha parsing and serialization to adhere to W3 standard.

Specifically, a 2.55 multiplication factor should be used, and
serialization should be to two or three digits according to section
<alphavalue> in https://drafts.csswg.org/cssom/#serializing-css-values

This fixes test case "background-color: rgba(5, 7, 10, 0.5)" in
https://w3c-test.org/cssom/serialize-values.html

Note a large number of tests need to be fixed, many of them because:
- *-expected.txt specifically had bad alpha values such as 0.501961 or
- an alpha value of 0.5 was previously 127 but should have been 128.
The latter applies to the updated expected images too where the only
difference was tiny bit of alpha (and rgb when alpha blended) change.

BUG=453414
==========

to

==========
Fix RGBA alpha parsing and serialization to adhere to W3 standard.

Specifically, a 2.55 multiplication factor should be used, and
serialization should be to two or three digits according to section
<alphavalue> in https://drafts.csswg.org/cssom/#serializing-css-values

This fixes test case "background-color: rgba(5, 7, 10, 0.5)" in
https://w3c-test.org/cssom/serialize-values.html and also that the
implementation is now same as Firefox as noted in the bug.

Note a large number of tests need to be fixed, many of them because:
- *-expected.txt specifically had bad alpha values such as 0.501961 or
- an alpha value of 0.5 was previously 127 but should have been 128.
The latter applies to the updated expected images too where the only
difference was tiny bit of alpha (and rgb when alpha blended) change.

BUG=453414
==========

[ktyliu, 2017-01-08 21:34:53]

The CQ bit was checked by ktyliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-08 21:35:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ktyliu, 2017-01-08 22:01:09]

Original bug have Interop label already, and have attached screenshot to the
bug. Also mention that we have same implementation as Firefox in issue
description.

Thanks.

https://codereview.chromium.org/2608423002/diff/80001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/css-parser/serialize-css-alpha-value.html
(right):

https://codereview.chromium.org/2608423002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/css-parser/serialize-css-alpha-value.html:2:
<title>Floating point alpha value parssing and serialization</title>
Removed <title> and fixed documentation in separate patch.
Thanks for pointing this out.

https://codereview.chromium.org/2608423002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/css-parser/serialize-css-alpha-value.html:14: },
'Alpha values with two decimals should parse and serialize to the same value');
On 2017/01/06 02:56:16, sashab wrote:
> How about, "Alpha values should parse and serialize to the same value to 2
> decimal places"

Done.

https://codereview.chromium.org/2608423002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/css-parser/serialize-css-alpha-value.html:30: },
'Expected alpha values with three decimals');
Updated wording and also test cases to highlight that we can have more decimals,
but would serialize to 1, 2, or 3 decimals according to spec.

Hope this is okay

[sashab, 2017-01-09 03:28:00]

LGTM, let's land this! :-)

[ktyliu, 2017-01-09 03:42:22]

The CQ bit was checked by ktyliu@chromium.org

[commit-bot: I haz the power, 2017-01-09 03:42:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 03:56:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 03:57:01]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[ktyliu, 2017-01-09 04:32:35]

ktyliu@chromium.org changed reviewers:
+ eae@chromium.org
- alancutter@chromium.org, bugsnash@chromium.org

[ktyliu, 2017-01-09 04:32:36]

Hi Emil,

Would you be able to help review this patch or suggest someone appropriate?
I saw you reviewed the last attempt at fixing the bug.

Thanks,
Kevin

[eae, 2017-01-09 17:27:48]

LGTM for Source/platform

[ktyliu, 2017-01-09 21:53:18]

The CQ bit was checked by ktyliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 21:53:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 00:04:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 00:04:12]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ktyliu, 2017-01-10 05:40:37]

The CQ bit was checked by ktyliu@chromium.org

[ktyliu, 2017-01-10 05:40:39]

The patchset sent to the CQ was uploaded after l-g-t-m from sashab@chromium.org,
eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2608423002/#ps160001
(title: "Rebaseline")

[commit-bot: I haz the power, 2017-01-10 05:41:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 07:51:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 07:51:24]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ktyliu, 2017-01-10 23:03:14]

The CQ bit was checked by ktyliu@chromium.org

[ktyliu, 2017-01-10 23:03:16]

The patchset sent to the CQ was uploaded after l-g-t-m from sashab@chromium.org,
eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2608423002/#ps180001
(title: "rebaseline")

[commit-bot: I haz the power, 2017-01-10 23:03:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 01:33:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 01:33:20]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ktyliu, 2017-01-11 03:11:16]

The CQ bit was checked by ktyliu@chromium.org

[ktyliu, 2017-01-11 03:11:18]

The patchset sent to the CQ was uploaded after l-g-t-m from sashab@chromium.org,
eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2608423002/#ps200001
(title: "rebaseline")

[commit-bot: I haz the power, 2017-01-11 03:12:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 04:01:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 04:01:05]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ktyliu, 2017-01-11 05:44:12]

The CQ bit was checked by ktyliu@chromium.org

[commit-bot: I haz the power, 2017-01-11 05:44:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 07:06:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 07:06:52]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ktyliu, 2017-01-11 07:44:19]

The CQ bit was checked by ktyliu@chromium.org

[commit-bot: I haz the power, 2017-01-11 07:44:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 08:51:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 08:51:35]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ktyliu, 2017-01-11 23:10:08]

The CQ bit was checked by ktyliu@chromium.org

[ktyliu, 2017-01-11 23:10:10]

The patchset sent to the CQ was uploaded after l-g-t-m from sashab@chromium.org,
eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2608423002/#ps220001
(title: "Add NeedsRebaseline for remaining 3 tests that continue to fail after
rebaseline-cl")

[commit-bot: I haz the power, 2017-01-11 23:10:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ktyliu, 2017-01-11 23:11:58]

Strangely rebaseline_cl fixed all but ~3 tests. The expected png seems to be
updated and the linux tests pass locally.

Sasha suggested adding the failed tests to TestExpectations with needs
rebaseline and see if that works

[commit-bot: I haz the power, 2017-01-11 23:20:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 23:20:25]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[ktyliu, 2017-01-11 23:22:50]

The CQ bit was checked by ktyliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 23:23:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ktyliu, 2017-01-11 23:30:12]

The CQ bit was checked by ktyliu@chromium.org

[ktyliu, 2017-01-11 23:30:14]

The patchset sent to the CQ was uploaded after l-g-t-m from sashab@chromium.org,
eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2608423002/#ps240001
(title: "Add NeedsRebaseline for remaining 3 tests that continue to fail after
rebaseline-cl")

[commit-bot: I haz the power, 2017-01-11 23:31:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ktyliu, 2017-01-12 01:45:22]

The CQ bit was checked by ktyliu@chromium.org

[ktyliu, 2017-01-12 01:45:24]

The patchset sent to the CQ was uploaded after l-g-t-m from sashab@chromium.org,
eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2608423002/#ps260001
(title: "Add NeedsRebaseline for 4 failed tests in Win/Linux/Mac")

[commit-bot: I haz the power, 2017-01-12 01:46:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 02:03:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 02:03:15]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[ktyliu, 2017-01-12 02:52:02]

The CQ bit was checked by ktyliu@chromium.org

[commit-bot: I haz the power, 2017-01-12 02:52:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 03:06:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 03:06:26]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[ktyliu, 2017-01-12 03:23:57]

The CQ bit was checked by ktyliu@chromium.org

[ktyliu, 2017-01-12 03:23:58]

The patchset sent to the CQ was uploaded after l-g-t-m from sashab@chromium.org,
eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2608423002/#ps280001
(title: "NeedsRebaseline for failed layout tests")

[commit-bot: I haz the power, 2017-01-12 03:24:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 03:35:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 03:35:36]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ktyliu, 2017-01-12 03:47:27]

The CQ bit was checked by ktyliu@chromium.org

[commit-bot: I haz the power, 2017-01-12 03:47:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 04:59:38]

CQ is committing da patch.

Bot data: {"patchset_id": 280001, "attempt_start_ts": 1484192847432330,
"parent_rev": "0c13a0b61a5ca9950be7796af8c480429b03e87a", "commit_rev":
"13a86c2faeebcbc12dd4a7e8dea54318da635c19"}

[commit-bot: I haz the power, 2017-01-12 05:00:32]

Description was changed from

==========
Fix RGBA alpha parsing and serialization to adhere to W3 standard.

Specifically, a 2.55 multiplication factor should be used, and
serialization should be to two or three digits according to section
<alphavalue> in https://drafts.csswg.org/cssom/#serializing-css-values

This fixes test case "background-color: rgba(5, 7, 10, 0.5)" in
https://w3c-test.org/cssom/serialize-values.html and also that the
implementation is now same as Firefox as noted in the bug.

Note a large number of tests need to be fixed, many of them because:
- *-expected.txt specifically had bad alpha values such as 0.501961 or
- an alpha value of 0.5 was previously 127 but should have been 128.
The latter applies to the updated expected images too where the only
difference was tiny bit of alpha (and rgb when alpha blended) change.

BUG=453414
==========

to

==========
Fix RGBA alpha parsing and serialization to adhere to W3 standard.

Specifically, a 2.55 multiplication factor should be used, and
serialization should be to two or three digits according to section
<alphavalue> in https://drafts.csswg.org/cssom/#serializing-css-values

This fixes test case "background-color: rgba(5, 7, 10, 0.5)" in
https://w3c-test.org/cssom/serialize-values.html and also that the
implementation is now same as Firefox as noted in the bug.

Note a large number of tests need to be fixed, many of them because:
- *-expected.txt specifically had bad alpha values such as 0.501961 or
- an alpha value of 0.5 was previously 127 but should have been 128.
The latter applies to the updated expected images too where the only
difference was tiny bit of alpha (and rgb when alpha blended) change.

BUG=453414

Review-Url: https://codereview.chromium.org/2608423002
Cr-Commit-Position: refs/heads/master@{#443157}
Committed:
https://chromium.googlesource.com/chromium/src/+/13a86c2faeebcbc12dd4a7e8dea5...
==========

[commit-bot: I haz the power, 2017-01-12 05:00:36]

Committed patchset #15 (id:280001) as
https://chromium.googlesource.com/chromium/src/+/13a86c2faeebcbc12dd4a7e8dea5...