third_party/WebKit/LayoutTests/css-parser/serialize-css-alpha-value.html - Issue 2608423002: Fix RGBA alpha parsing and serialization to adhere to W3 standard.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/css-parser/serialize-css-alpha-value.html

Issue 2608423002: Fix RGBA alpha parsing and serialization to adhere to W3 standard. (Closed)

Patch Set: Rebaseline expectations for win and mac Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/css-parser/color3-expected.txt ('k') | third_party/WebKit/LayoutTests/css3/calc/color-hsl-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>Harness Test: Floating point alpha values of numbers to two decimial plac es are serialized and returned correctly.</title>
	sashab 2017/01/05 04:10:34 Typo: decimal Typo: decimal ktyliu 2017/01/06 01:58:30 Done. Show quoted text On 2017/01/05 04:10:34, sashab wrote: > Typo: decimal Done.
	3 <body>

	4 <script src="../resources/testharness.js"></script>

	5 <script src="../resources/testharnessreport.js"></script>

	6 <script>

	7 test(function() {

	8 for (var i = 0.0; i <= 1.0; i += 0.01) {
	sashab 2017/01/05 04:10:34 Maybe make it clearer that this used to fail for c Maybe make it clearer that this used to fail for certain values, so this test is for values like 0.1, 0.3, etc, the 0.01 is arbitrary but covers these failing values and others ktyliu 2017/01/06 01:58:30 actually almost all values would fail previously, actually almost all values would fail previously, as evident by going to http://software.hixie.ch/utilities/js/live-dom-viewer/?saved=3436 on Chrome and compare it with Firefox added test description to clarify it tests correct parsing and serialization of alpha with 2 decimals
	9 var rgba = 'rgba(0, 0, 0, ' + parseFloat(i.toFixed(2)) + ')';

	10 document.body.style.color = rgba;

	11 assert_equals(document.body.style.color, rgba);

	12 assert_equals(getComputedStyle(document.body).color, rgba);

	13 }

	14 });
	sashab 2017/01/05 04:10:34 Please add a title for this test - you can remove Please add a title for this test - you can remove the <title> tag and put it here instead sashab 2017/01/05 04:10:34 Please add a title for this test - you can remove Please add a title for this test - you can remove the <title> tag and put it here instead ktyliu 2017/01/06 01:58:30 Acknowledged. Show quoted text On 2017/01/05 04:10:34, sashab wrote: > Please add a title for this test - you can remove the <title> tag and put it > here instead Acknowledged. ktyliu 2017/01/06 01:58:30 I thought we should use <title> for a single test I thought we should use <title> for a single test case, which Bugs thought so too. Anyway, I've now added another test case to spot test a few three decimals, and made <title> describe the generic test context Hope that's okay alancutter (OOO until 2018) 2017/01/06 02:47:00 Calls to test() should come with a description par Show quoted text On 2017/01/06 at 01:58:30, ktyliu wrote: > I thought we should use <title> for a single test case, which Bugs thought so too. Calls to test() should come with a description parameter as it's what shows up in the test output, <title> will not appear.
	15 </script>

	16

OLD	NEW