third_party/WebKit/LayoutTests/css-parser/serialize-css-alpha-value.html - Issue 2608423002: Fix RGBA alpha parsing and serialization to adhere to W3 standard.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/css-parser/serialize-css-alpha-value.html

Issue 2608423002: Fix RGBA alpha parsing and serialization to adhere to W3 standard. (Closed)

Patch Set: rebaseline Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/css-parser/color3-expected.txt ('k') | third_party/WebKit/LayoutTests/css3/calc/color-hsl-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>Floating point alpha value parssing and serialization</title>
	sashab 2017/01/06 02:56:16 Do we have lots of other layout tests like this? G Do we have lots of other layout tests like this? Generally the format I've seen in tests is like: <!DOCTYPE html> <script src=... testharness includes> <script> { test goes here } </script> I'm happy to leave it if you think it's self-documenting, but just not sure if other tests have it, and as alancutter@ said it won't be seen on test failure (only the test title parameter will). ktyliu 2017/01/08 22:01:09 Removed <title> and fixed documentation in separat Removed <title> and fixed documentation in separate patch. Thanks for pointing this out.
	3 <body>

	4 <script src="../resources/testharness.js"></script>

	5 <script src="../resources/testharnessreport.js"></script>

	6 <script>

	7 test(function() {

	8 for (var i = 0.0; i <= 1.0; i += 0.01) {

	9 var rgba = 'rgba(0, 0, 0, ' + parseFloat(i.toFixed(2)) + ')';

	10 document.body.style.color = rgba;

	11 assert_equals(document.body.style.color, rgba);

	12 assert_equals(getComputedStyle(document.body).color, rgba);

	13 }

	14 }, 'Alpha values with two decimals should parse and serialize to the same value' );
	sashab 2017/01/06 02:56:16 How about, "Alpha values should parse and serializ How about, "Alpha values should parse and serialize to the same value to 2 decimal places" ktyliu 2017/01/08 22:01:09 Done. Show quoted text On 2017/01/06 02:56:16, sashab wrote: > How about, "Alpha values should parse and serialize to the same value to 2 > decimal places" Done.
	15

	16 test(function() {

	17 var testCases = [

	18 ['rgba(0, 0, 0, 0.004)', 'rgba(0, 0, 0, 0.004)'],

	19 ['rgba(0, 0, 0, 0.011)', 'rgba(0, 0, 0, 0.01)'],

	20 ['rgba(0, 0, 0, 0.016)', 'rgba(0, 0, 0, 0.016)'],

	21 ['rgba(0, 0, 0, 0.501)', 'rgba(0, 0, 0, 0.5)']

	22 ];

	23 for (var i = 0; i < testCases.length; ++i) {

	24 var rgba = testCases[i][0];

	25 var expected = testCases[i][1];

	26 document.body.style.color = rgba;

	27 assert_equals(document.body.style.color, expected);

	28 assert_equals(getComputedStyle(document.body).color, expected);

	29 }

	30 }, 'Expected alpha values with three decimals');
	sashab 2017/01/06 02:56:16 "Alpha values with three decimals should parse and "Alpha values with three decimals should parse and sometimes round up to the same value" (would be great if you could clarify the 'sometimes') ktyliu 2017/01/08 22:01:09 Updated wording and also test cases to highlight t Updated wording and also test cases to highlight that we can have more decimals, but would serialize to 1, 2, or 3 decimals according to spec. Hope this is okay
	31 </script>

	32

OLD	NEW