[ios] Moves tab_switcher code out of the ios_internal namespace.

ios/chrome/browser/ui/tab_switcher/tab_switcher_utils.mm

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/ui/tab_switcher/tab_switcher_utils.h"
 
 #import <UIKit/UIKit.h>
 
 #include "base/logging.h"
 #include "base/mac/scoped_nsobject.h"
 #include "components/browser_sync/profile_sync_service.h"
 #include "components/sync/driver/sync_service.h"
 #include "components/sync_sessions/open_tabs_ui_delegate.h"
 #include "ios/chrome/browser/browser_state/chrome_browser_state.h"
 #import "ios/chrome/browser/favicon/favicon_loader.h"
 #include "ios/chrome/browser/favicon/ios_chrome_favicon_loader_factory.h"
 #include "ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.h"
 #import "ios/chrome/browser/ui/uikit_ui_util.h"
 #include "ios/chrome/grit/ios_theme_resources.h"
 
-namespace ios_internal {
+namespace {
 
 UIImage* DefaultFaviconImage() {
   return NativeImage(IDR_IOS_OMNIBOX_HTTP);
 }
 
-void GetFavicon(GURL const& url,
-                ios::ChromeBrowserState* browser_state,
-                ios_internal::FaviconGetterCompletionBlock block) {
+enum BacktrackOperation { NOTHING, SUBSTITUTION, DELETION, INSERTION };
+
+BacktrackOperation BacktrackOperationInCostMatrix(
+    std::vector<std::vector<int>> const& costMatrix,

[sdefresne, 2017/01/03 16:04:30]

nit: this is a C++ function so it should use
cpp_naming_convention_for_local_variables_and_parameters.

s/costMatrix/cost_matrix/
s/finalIndex/final_index/
...

[rohitrao (ping after 24h), 2017/01/04 13:36:38]

Acknowledged.

+    size_t finalIndex,
+    size_t initialIndex) {
+  DCHECK(finalIndex || initialIndex);
+  DCHECK(initialIndex < costMatrix.size());
+  DCHECK(finalIndex < costMatrix[initialIndex].size());
+
+  if (finalIndex == 0)
+    return DELETION;
+  if (initialIndex == 0)
+    return INSERTION;
+
+  int currentCost = costMatrix[initialIndex][finalIndex];
+
+  int costBeforeInsertion = costMatrix[initialIndex][finalIndex - 1];
+  if (costBeforeInsertion + 1 == currentCost)
+    return INSERTION;
+
+  int costBeforeDeletion = costMatrix[initialIndex - 1][finalIndex];
+  if (costBeforeDeletion + 1 == currentCost)
+    return DELETION;
+
+  int costBeforeSubstitution = costMatrix[initialIndex - 1][finalIndex - 1];
+  if (costBeforeSubstitution == currentCost)
+    return NOTHING;
+
+  return SUBSTITUTION;
+}
+
+}  // namespace
+
+void TabSwitcherGetFavicon(GURL const& url,
+                           ios::ChromeBrowserState* browser_state,
+                           TabSwitcherFaviconGetterCompletionBlock block) {
   DCHECK(browser_state);
   syncer::SyncService* sync_service =
       IOSChromeProfileSyncServiceFactory::GetForBrowserState(browser_state);
   sync_sessions::OpenTabsUIDelegate* open_tabs =
       sync_service ? sync_service->GetOpenTabsUIDelegate() : NULL;
   scoped_refptr<base::RefCountedMemory> favicon;
   if (open_tabs &&
       open_tabs->GetSyncedFaviconForPageURL(url.spec(), &favicon)) {
     dispatch_queue_t queue =
         dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_LOW, 0);
@@ skipping 23 matching lines @@
                 favicon_base::TOUCH_PRECOMPOSED_ICON;
     UIImage* image = loader->ImageForURL(url, types, block);
     DCHECK(image);
     block(image);
     return;
   }
   // Finally returns a default image.
   block(DefaultFaviconImage());
 }
 
-enum BacktrackOperation { NOTHING, SUBSTITUTION, DELETION, INSERTION };
-
-BacktrackOperation BacktrackOperationInCostMatrix(
-    std::vector<std::vector<int>> const& costMatrix,
-    size_t finalIndex,
-    size_t initialIndex) {
-  DCHECK(finalIndex || initialIndex);
-  DCHECK(initialIndex < costMatrix.size());
-  DCHECK(finalIndex < costMatrix[initialIndex].size());
-
-  if (finalIndex == 0)
-    return DELETION;
-  if (initialIndex == 0)
-    return INSERTION;
-
-  int currentCost = costMatrix[initialIndex][finalIndex];
-
-  int costBeforeInsertion = costMatrix[initialIndex][finalIndex - 1];
-  if (costBeforeInsertion + 1 == currentCost)
-    return INSERTION;
-
-  int costBeforeDeletion = costMatrix[initialIndex - 1][finalIndex];
-  if (costBeforeDeletion + 1 == currentCost)
-    return DELETION;
-
-  int costBeforeSubstitution = costMatrix[initialIndex - 1][finalIndex - 1];
-  if (costBeforeSubstitution == currentCost)
-    return NOTHING;
-
-  return SUBSTITUTION;
-}
-
-void MinimalReplacementOperations(std::vector<size_t> const& initial,
-                                  std::vector<size_t> const& final,
-                                  std::vector<size_t>* substitutions,
-                                  std::vector<size_t>* deletions,
-                                  std::vector<size_t>* insertions) {
+void TabSwitcherMinimalReplacementOperations(std::vector<size_t> const& initial,
+                                             std::vector<size_t> const& final,
+                                             std::vector<size_t>* substitutions,
+                                             std::vector<size_t>* deletions,
+                                             std::vector<size_t>* insertions) {
   DCHECK(substitutions);
   DCHECK(deletions);
   DCHECK(insertions);
   DCHECK_EQ(substitutions->size(), 0UL);
   DCHECK_EQ(deletions->size(), 0UL);
   DCHECK_EQ(insertions->size(), 0UL);
 
   // The substitutions/deletions/insertions are computed using the Levenshtein
   // algorithm.
   // https://en.wikipedia.org/wiki/Levenshtein_distance
@@ skipping 58 matching lines @@
     }
   }
 
   // The backtracking results in the indexes of the operations being stored in
   // decreasing order.
   // For readability, order them in ascending value.
   std::reverse(std::begin(*substitutions), std::end(*substitutions));
   std::reverse(std::begin(*deletions), std::end(*deletions));
   std::reverse(std::begin(*insertions), std::end(*insertions));
 }
-
-}  // namespace ios_internal