DevTools: extract modules (with extensions)

DevTools: extract modules (with extensions)

This needs to land prior to my CL for speeding up closure by
enforcing dependencies by poisoning namespaces:
https://codereview.chromium.org/2588843002

Almost all of the changes were generated from extract_module.js with
the exceptions of:
- rebaselining initial-modules-load-expected.txt and 
open-with-rendering-option-enabled-expected.txt
- added module->namespace mapping logic to Runtime.js
- build_release_applications.py uses module_to_namespaces.json which is similar
to Runtime.js namespace mapping (to be used by the dependency preprocessor
in the other CL)
- adding namespaces to externs.js

BUG=none

Review-Url: https://codereview.chromium.org/2608043002
Cr-Commit-Position: refs/heads/master@{#442469}
Committed: https://chromium.googlesource.com/chromium/src/+/75219898c08d3019046d34d47150277d484f9bd4

[chenwilliam, 2017-01-05 02:22:27]

Description was changed from

==========
DevTools: extract modules


script


update GN


extract-module

BUG=
==========

to

==========
DevTools: extract modules from ui_lazy, component_lazy & others

This needs to land prior to my CL for speeding up closure by
enforcing dependencies by poisoning namespaces:
https://codereview.chromium.org/2588843002

Almost all of the changes were generated from extract_modules.js with
the exceptions of:
- rebaselining initial-modules-load-expected.txt and 
open-with-rendering-option-enabled-expected.txt
- moving front_end/ui_lazy/dialog.css -> front_end/sources/dialog.css
(it was the only user of the file)
- added module->namespace mapping logic to Runtime.js
- adding namespaces to externs.js
- build_release_applications.py uses module_to_namespaces.json which is similar
to Runtime.js namespace mapping (to be used by the dependency preprocessor
in the other CL)

BUG=none
==========

[chenwilliam, 2017-01-05 02:23:22]

Description was changed from

==========
DevTools: extract modules from ui_lazy, component_lazy & others

This needs to land prior to my CL for speeding up closure by
enforcing dependencies by poisoning namespaces:
https://codereview.chromium.org/2588843002

Almost all of the changes were generated from extract_modules.js with
the exceptions of:
- rebaselining initial-modules-load-expected.txt and 
open-with-rendering-option-enabled-expected.txt
- moving front_end/ui_lazy/dialog.css -> front_end/sources/dialog.css
(it was the only user of the file)
- added module->namespace mapping logic to Runtime.js
- adding namespaces to externs.js
- build_release_applications.py uses module_to_namespaces.json which is similar
to Runtime.js namespace mapping (to be used by the dependency preprocessor
in the other CL)

BUG=none
==========

to

==========
DevTools: extract modules from ui_lazy, component_lazy & others

This needs to land prior to my CL for speeding up closure by
enforcing dependencies by poisoning namespaces:
https://codereview.chromium.org/2588843002

Almost all of the changes were generated from extract_modules.js with
the exceptions of:
- rebaselining initial-modules-load-expected.txt and 
open-with-rendering-option-enabled-expected.txt
- moving front_end/ui_lazy/dialog.css -> front_end/sources/dialog.css
(it was the only user of the file)
- added module->namespace mapping logic to Runtime.js
- build_release_applications.py uses module_to_namespaces.json which is similar
to Runtime.js namespace mapping (to be used by the dependency preprocessor
in the other CL)
- adding namespaces to externs.js

BUG=none
==========

[chenwilliam, 2017-01-05 02:26:18]

Description was changed from

==========
DevTools: extract modules from ui_lazy, component_lazy & others

This needs to land prior to my CL for speeding up closure by
enforcing dependencies by poisoning namespaces:
https://codereview.chromium.org/2588843002

Almost all of the changes were generated from extract_modules.js with
the exceptions of:
- rebaselining initial-modules-load-expected.txt and 
open-with-rendering-option-enabled-expected.txt
- moving front_end/ui_lazy/dialog.css -> front_end/sources/dialog.css
(it was the only user of the file)
- added module->namespace mapping logic to Runtime.js
- build_release_applications.py uses module_to_namespaces.json which is similar
to Runtime.js namespace mapping (to be used by the dependency preprocessor
in the other CL)
- adding namespaces to externs.js

BUG=none
==========

to

==========
DevTools: extract modules from ui_lazy, component_lazy & others

This needs to land prior to my CL for speeding up closure by
enforcing dependencies by poisoning namespaces:
https://codereview.chromium.org/2588843002

Almost all of the changes were generated from extract_module.js with
the exceptions of:
- rebaselining initial-modules-load-expected.txt and 
open-with-rendering-option-enabled-expected.txt
- moving front_end/ui_lazy/dialog.css -> front_end/sources/dialog.css
(it was the only user of the file)
- added module->namespace mapping logic to Runtime.js
- build_release_applications.py uses module_to_namespaces.json which is similar
to Runtime.js namespace mapping (to be used by the dependency preprocessor
in the other CL)
- adding namespaces to externs.js

BUG=none
==========

[chenwilliam, 2017-01-05 20:21:14]

chenwilliam@chromium.org changed reviewers:
+ dgozman@chromium.org, pfeldman@chromium.org

[chenwilliam, 2017-01-05 20:21:16]

PTAL. It's a big patch so it might be helpful to review the top of
extract_module.js to see what the changes are at a high-level.

[pfeldman, 2017-01-05 20:27:53]

Could you upload one with no formatting changes to module.json? I'd like to see
changes to those at a high level.

https://codereview.chromium.org/2608043002/diff/30001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/components/module.json
(right):

https://codereview.chromium.org/2608043002/diff/30001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/module.json:2:
"extensions": [
single quote these?

[chenwilliam, 2017-01-05 22:40:25]

PTAL. I've uploaded a CL w/ a cleaner diff of the module.json files:

https://codereview.chromium.org/2612383002

(There's still a little bit of formatting noise but it's readable)

https://codereview.chromium.org/2608043002/diff/30001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/components/module.json
(right):

https://codereview.chromium.org/2608043002/diff/30001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/module.json:2:
"extensions": [
On 2017/01/05 20:27:53, pfeldman wrote:
> single quote these?

JSON spec requires double quotes :(

[pfeldman, 2017-01-06 00:07:09]

https://codereview.chromium.org/2608043002/diff/30001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/components/module.json
(right):

https://codereview.chromium.org/2608043002/diff/30001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/module.json:2:
"extensions": [
On 2017/01/05 22:40:25, chenwilliam wrote:
> On 2017/01/05 20:27:53, pfeldman wrote:
> > single quote these?
> 
> JSON spec requires double quotes :(

Ah! Maybe leave 4 spaces then? :) I still can't see the diff....

[alancutter (OOO until 2018), 2017-01-06 00:26:42]

alancutter@chromium.org changed reviewers:
+ alancutter@chromium.org

[alancutter (OOO until 2018), 2017-01-06 00:26:43]

https://codereview.chromium.org/2608043002/diff/30001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/components/module.json
(right):

https://codereview.chromium.org/2608043002/diff/30001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/module.json:2:
"extensions": [
On 2017/01/06 at 00:07:09, pfeldman wrote:
> On 2017/01/05 22:40:25, chenwilliam wrote:
> > On 2017/01/05 20:27:53, pfeldman wrote:
> > > single quote these?
> > 
> > JSON spec requires double quotes :(
> 
> Ah! Maybe leave 4 spaces then? :) I still can't see the diff....

The side-by-side diff accounts for the change in indentation and is much easier
to see the diff in.

[pfeldman, 2017-01-06 18:46:55]

> The side-by-side diff accounts for the change in indentation and is much
easier
> to see the diff in.

Those two statements were unrelated - I'm using side-by-side, but Will
incorporated some formatting changes into the patch.

[dgozman, 2017-01-06 19:34:20]

On 2017/01/06 18:46:55, pfeldman wrote:
> > The side-by-side diff accounts for the change in indentation and is much
> easier
> > to see the diff in.
> 
> Those two statements were unrelated - I'm using side-by-side, but Will
> incorporated some formatting changes into the patch.

+1, let's not format module.json at all?

[chenwilliam, 2017-01-07 02:13:32]

Patchset #6 (id:50001) has been deleted

[chenwilliam, 2017-01-07 03:16:07]

Patchset #6 (id:70001) has been deleted

[chenwilliam, 2017-01-07 03:22:52]

PTAL - I uploaded a patchset that only affects the files that changed extensions
+ moving two files to source_frame (so network doesn't need to depend on
sources). It's difficult to not format the json files because I'm using
JSON.parse and stringify but hopefully the diffs are manageable now.

[chenwilliam, 2017-01-09 19:06:20]

Description was changed from

==========
DevTools: extract modules from ui_lazy, component_lazy & others

This needs to land prior to my CL for speeding up closure by
enforcing dependencies by poisoning namespaces:
https://codereview.chromium.org/2588843002

Almost all of the changes were generated from extract_module.js with
the exceptions of:
- rebaselining initial-modules-load-expected.txt and 
open-with-rendering-option-enabled-expected.txt
- moving front_end/ui_lazy/dialog.css -> front_end/sources/dialog.css
(it was the only user of the file)
- added module->namespace mapping logic to Runtime.js
- build_release_applications.py uses module_to_namespaces.json which is similar
to Runtime.js namespace mapping (to be used by the dependency preprocessor
in the other CL)
- adding namespaces to externs.js

BUG=none
==========

to

==========
DevTools: extract modules (with extensions)

This needs to land prior to my CL for speeding up closure by
enforcing dependencies by poisoning namespaces:
https://codereview.chromium.org/2588843002

Almost all of the changes were generated from extract_module.js with
the exceptions of:
- rebaselining initial-modules-load-expected.txt and 
open-with-rendering-option-enabled-expected.txt
- moving front_end/ui_lazy/dialog.css -> front_end/sources/dialog.css
(it was the only user of the file)
- added module->namespace mapping logic to Runtime.js
- build_release_applications.py uses module_to_namespaces.json which is similar
to Runtime.js namespace mapping (to be used by the dependency preprocessor
in the other CL)
- adding namespaces to externs.js

BUG=none
==========

[chenwilliam, 2017-01-09 19:13:19]

PTAL - just uploaded a patchset with a small refactoring of the python (module
-> namespaces). This is in addition to the Fri patchset that minimizes the diff
as it focuses on extracting modules that touches extensions.

[pfeldman, 2017-01-09 19:29:48]

https://codereview.chromium.org/2608043002/diff/110001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/BUILD.gn (right):

https://codereview.chromium.org/2608043002/diff/110001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/BUILD.gn:455: "front_end/sources/dialog.css",
Why is this guy getting here?

https://codereview.chromium.org/2608043002/diff/110001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/Runtime.js (right):

https://codereview.chromium.org/2608043002/diff/110001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/Runtime.js:781: 'perf_ui':
'Perf_UI',
PerfUI

https://codereview.chromium.org/2608043002/diff/110001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/css_tracker/module.json
(right):

https://codereview.chromium.org/2608043002/diff/110001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/css_tracker/module.json:14: "type":
"@SourceFrame.UISourceCodeFrame.LineDecorator",
Yay, now css_tracker -> sources dependency can be replaced with the one from
source_frame.

https://codereview.chromium.org/2608043002/diff/110001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/resources/module.json (right):

https://codereview.chromium.org/2608043002/diff/110001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/resources/module.json:22:
"components_lazy",
No need to change this file.

https://codereview.chromium.org/2608043002/diff/110001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/settings/module.json (right):

https://codereview.chromium.org/2608043002/diff/110001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/settings/module.json:93: "main"
Nothing depends on main!

https://codereview.chromium.org/2608043002/diff/110001/third_party/WebKit/Sou...
File
third_party/WebKit/Source/devtools/front_end/sources/AddSourceMapURLDialog.js
(right):

https://codereview.chromium.org/2608043002/diff/110001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/sources/AddSourceMapURLDialog.js:13:
this.registerRequiredCSS('sources/dialog.css');
It should rather be in ui/

https://codereview.chromium.org/2608043002/diff/110001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/scripts/special_case_namespaces.json
(right):

https://codereview.chromium.org/2608043002/diff/110001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/scripts/special_case_namespaces.json:4:
"js_ui": "JS_UI",
We don't have it now, right?

https://codereview.chromium.org/2608043002/diff/110001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/scripts/special_case_namespaces.json:5:
"perf_ui": "Perf_UI",
Should be PerfUI.

[chenwilliam, 2017-01-09 22:25:39]

Description was changed from

==========
DevTools: extract modules (with extensions)

This needs to land prior to my CL for speeding up closure by
enforcing dependencies by poisoning namespaces:
https://codereview.chromium.org/2588843002

Almost all of the changes were generated from extract_module.js with
the exceptions of:
- rebaselining initial-modules-load-expected.txt and 
open-with-rendering-option-enabled-expected.txt
- moving front_end/ui_lazy/dialog.css -> front_end/sources/dialog.css
(it was the only user of the file)
- added module->namespace mapping logic to Runtime.js
- build_release_applications.py uses module_to_namespaces.json which is similar
to Runtime.js namespace mapping (to be used by the dependency preprocessor
in the other CL)
- adding namespaces to externs.js

BUG=none
==========

to

==========
DevTools: extract modules (with extensions)

This needs to land prior to my CL for speeding up closure by
enforcing dependencies by poisoning namespaces:
https://codereview.chromium.org/2588843002

Almost all of the changes were generated from extract_module.js with
the exceptions of:
- rebaselining initial-modules-load-expected.txt and 
open-with-rendering-option-enabled-expected.txt
- added module->namespace mapping logic to Runtime.js
- build_release_applications.py uses module_to_namespaces.json which is similar
to Runtime.js namespace mapping (to be used by the dependency preprocessor
in the other CL)
- adding namespaces to externs.js

BUG=none
==========

[chenwilliam, 2017-01-09 22:49:14]

chenwilliam@chromium.org changed reviewers:
- alancutter@chromium.org

[chenwilliam, 2017-01-09 22:49:16]

PTAL.

https://codereview.chromium.org/2608043002/diff/110001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/BUILD.gn (right):

https://codereview.chromium.org/2608043002/diff/110001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/BUILD.gn:455: "front_end/sources/dialog.css",
On 2017/01/09 19:29:48, pfeldman wrote:
> Why is this guy getting here?

Please see response to other comment.

https://codereview.chromium.org/2608043002/diff/110001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/Runtime.js (right):

https://codereview.chromium.org/2608043002/diff/110001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/Runtime.js:781: 'perf_ui':
'Perf_UI',
On 2017/01/09 19:29:48, pfeldman wrote:
> PerfUI

Done.

https://codereview.chromium.org/2608043002/diff/110001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/css_tracker/module.json
(right):

https://codereview.chromium.org/2608043002/diff/110001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/css_tracker/module.json:14: "type":
"@SourceFrame.UISourceCodeFrame.LineDecorator",
On 2017/01/09 19:29:48, pfeldman wrote:
> Yay, now css_tracker -> sources dependency can be replaced with the one from
> source_frame.

Done.

https://codereview.chromium.org/2608043002/diff/110001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/resources/module.json (right):

https://codereview.chromium.org/2608043002/diff/110001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/resources/module.json:22:
"components_lazy",
On 2017/01/09 19:29:48, pfeldman wrote:
> No need to change this file.

Done.

https://codereview.chromium.org/2608043002/diff/110001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/settings/module.json (right):

https://codereview.chromium.org/2608043002/diff/110001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/settings/module.json:93: "main"
On 2017/01/09 19:29:48, pfeldman wrote:
> Nothing depends on main!

Sorry!

https://codereview.chromium.org/2608043002/diff/110001/third_party/WebKit/Sou...
File
third_party/WebKit/Source/devtools/front_end/sources/AddSourceMapURLDialog.js
(right):

https://codereview.chromium.org/2608043002/diff/110001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/sources/AddSourceMapURLDialog.js:13:
this.registerRequiredCSS('sources/dialog.css');
On 2017/01/09 19:29:48, pfeldman wrote:
> It should rather be in ui/

I've reverted my change to ui_lazy/dialog.css in my latest patchset. I can't
move it to ui/ because there's an existing dialog.css and they diverge a bit. 

I originally moved it to sources/ because it can't stay in ui_lazy. I can create
a separate CL to manually move it to sources/ or ui/ and rename it to
sources_dialog.css?

https://codereview.chromium.org/2608043002/diff/110001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/scripts/special_case_namespaces.json
(right):

https://codereview.chromium.org/2608043002/diff/110001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/scripts/special_case_namespaces.json:4:
"js_ui": "JS_UI",
On 2017/01/09 19:29:48, pfeldman wrote:
> We don't have it now, right?

Right.

https://codereview.chromium.org/2608043002/diff/110001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/scripts/special_case_namespaces.json:5:
"perf_ui": "Perf_UI",
On 2017/01/09 19:29:48, pfeldman wrote:
> Should be PerfUI.

Done.

[pfeldman, 2017-01-09 23:19:08]

lgtm, we can move dialog.css later.

[chenwilliam, 2017-01-09 23:35:55]

The CQ bit was checked by chenwilliam@chromium.org

[commit-bot: I haz the power, 2017-01-09 23:37:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chenwilliam, 2017-01-09 23:56:02]

The CQ bit was unchecked by chenwilliam@chromium.org

[chenwilliam, 2017-01-10 00:03:13]

The CQ bit was checked by chenwilliam@chromium.org

[chenwilliam, 2017-01-10 00:03:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2608043002/#ps150001
(title: "fix externs (PerfUI)")

[commit-bot: I haz the power, 2017-01-10 00:03:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 04:10:43]

CQ is committing da patch.

Bot data: {"patchset_id": 150001, "attempt_start_ts": 1484006593515430,
"parent_rev": "da14777e6c930c32e9f63a82ada27496d7a2596b", "commit_rev":
"75219898c08d3019046d34d47150277d484f9bd4"}

[commit-bot: I haz the power, 2017-01-10 04:11:14]

Description was changed from

==========
DevTools: extract modules (with extensions)

This needs to land prior to my CL for speeding up closure by
enforcing dependencies by poisoning namespaces:
https://codereview.chromium.org/2588843002

Almost all of the changes were generated from extract_module.js with
the exceptions of:
- rebaselining initial-modules-load-expected.txt and 
open-with-rendering-option-enabled-expected.txt
- added module->namespace mapping logic to Runtime.js
- build_release_applications.py uses module_to_namespaces.json which is similar
to Runtime.js namespace mapping (to be used by the dependency preprocessor
in the other CL)
- adding namespaces to externs.js

BUG=none
==========

to

==========
DevTools: extract modules (with extensions)

This needs to land prior to my CL for speeding up closure by
enforcing dependencies by poisoning namespaces:
https://codereview.chromium.org/2588843002

Almost all of the changes were generated from extract_module.js with
the exceptions of:
- rebaselining initial-modules-load-expected.txt and 
open-with-rendering-option-enabled-expected.txt
- added module->namespace mapping logic to Runtime.js
- build_release_applications.py uses module_to_namespaces.json which is similar
to Runtime.js namespace mapping (to be used by the dependency preprocessor
in the other CL)
- adding namespaces to externs.js

BUG=none

Review-Url: https://codereview.chromium.org/2608043002
Cr-Commit-Position: refs/heads/master@{#442469}
Committed:
https://chromium.googlesource.com/chromium/src/+/75219898c08d3019046d34d47150...
==========

[commit-bot: I haz the power, 2017-01-10 04:11:15]

Committed patchset #9 (id:150001) as
https://chromium.googlesource.com/chromium/src/+/75219898c08d3019046d34d47150...