third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js - Issue 2608043002: DevTools: extract modules (with extensions)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

Issue 2608043002: DevTools: extract modules (with extensions) (Closed)

Patch Set: fix externs (PerfUI) Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sources/SourceCodeDiff.js ('k') | third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js b/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

index 9bd0b4e021b8edd6eb5d70d3eda5befffd00d35d..214762e6a0d4033ce89d766522f847920d0c885d 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

@@ -843,7 +843,7 @@ Sources.SourcesPanel = class extends UI.Panel {

* @param {!Object} target

_appendUISourceCodeFrameItems(event, contextMenu, target) {

- if (!(target instanceof Sources.UISourceCodeFrame))

+ if (!(target instanceof SourceFrame.UISourceCodeFrame))

return;

contextMenu.appendAction('debugger.evaluate-selection');

}

@@ -1262,7 +1262,7 @@ Sources.SourcesPanel.DebuggingActionDelegate = class {

panel._toggleBreakpointsActive();

return true;

case 'debugger.evaluate-selection':

- var frame = UI.context.flavor(Sources.UISourceCodeFrame);

+ var frame = UI.context.flavor(SourceFrame.UISourceCodeFrame);

if (frame) {

var text = frame.textEditor.text(frame.textEditor.selection());

var executionContext = UI.context.flavor(SDK.ExecutionContext);