Created test verifying resetting the state object after reloading.

Created test verifying resetting the state object after reloading.

BUG=673022
Review-Url: https://codereview.chromium.org/2607603005
Cr-Commit-Position: refs/heads/master@{#445847}
Committed: https://chromium.googlesource.com/chromium/src/+/c2b24b67da5f5bd50afe510e86b25888faba3d7d

[kkhorimoto, 2016-12-29 04:02:48]

kkhorimoto@chromium.org changed reviewers:
+ eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2016-12-29 17:15:28]

lgtm

https://codereview.chromium.org/2607603005/diff/1/ios/web/navigation/history_...
File ios/web/navigation/history_state_operations_inttest.mm (right):

https://codereview.chromium.org/2607603005/diff/1/ios/web/navigation/history_...
ios/web/navigation/history_state_operations_inttest.mm:351: std::string
empty_title("");
std::string empty_title;

https://codereview.chromium.org/2607603005/diff/1/ios/web/navigation/history_...
ios/web/navigation/history_state_operations_inttest.mm:352: GURL empty_url("");
GURL empty_url;

https://codereview.chromium.org/2607603005/diff/1/ios/web/navigation/history_...
ios/web/navigation/history_state_operations_inttest.mm:362:
web_state()->ExecuteJavaScript(
Could you please use synchronous API for this.

https://codereview.chromium.org/2607603005/diff/1/ios/web/navigation/history_...
ios/web/navigation/history_state_operations_inttest.mm:373:
EXPECT_TRUE(state_object_present);
No need for this check.

[kkhorimoto, 2017-01-24 05:15:36]

https://codereview.chromium.org/2607603005/diff/1/ios/web/navigation/history_...
File ios/web/navigation/history_state_operations_inttest.mm (right):

https://codereview.chromium.org/2607603005/diff/1/ios/web/navigation/history_...
ios/web/navigation/history_state_operations_inttest.mm:351: std::string
empty_title("");
On 2016/12/29 17:15:27, Eugene But wrote:
> std::string empty_title;

Done.

https://codereview.chromium.org/2607603005/diff/1/ios/web/navigation/history_...
ios/web/navigation/history_state_operations_inttest.mm:352: GURL empty_url("");
On 2016/12/29 17:15:27, Eugene But wrote:
> GURL empty_url;

Done.

https://codereview.chromium.org/2607603005/diff/1/ios/web/navigation/history_...
ios/web/navigation/history_state_operations_inttest.mm:362:
web_state()->ExecuteJavaScript(
On 2016/12/29 17:15:27, Eugene But wrote:
> Could you please use synchronous API for this.

Done.

https://codereview.chromium.org/2607603005/diff/1/ios/web/navigation/history_...
ios/web/navigation/history_state_operations_inttest.mm:373:
EXPECT_TRUE(state_object_present);
On 2016/12/29 17:15:27, Eugene But wrote:
> No need for this check.

Done.

[kkhorimoto, 2017-01-24 22:33:14]

The CQ bit was checked by kkhorimoto@chromium.org

[kkhorimoto, 2017-01-24 22:33:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2607603005/#ps20001
(title: "rebase + eugene's comments")

[commit-bot: I haz the power, 2017-01-24 22:34:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 22:47:28]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485297194143800,
"parent_rev": "22b7b42602956cc363a44cddf41c8bbeff1757d7", "commit_rev":
"c2b24b67da5f5bd50afe510e86b25888faba3d7d"}

[commit-bot: I haz the power, 2017-01-24 22:48:02]

Description was changed from

==========
Created test verifying resetting the state object after reloading.

BUG=673022
==========

to

==========
Created test verifying resetting the state object after reloading.

BUG=673022

Review-Url: https://codereview.chromium.org/2607603005
Cr-Commit-Position: refs/heads/master@{#445847}
Committed:
https://chromium.googlesource.com/chromium/src/+/c2b24b67da5f5bd50afe510e86b2...
==========

[commit-bot: I haz the power, 2017-01-24 22:48:03]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c2b24b67da5f5bd50afe510e86b2...