Created test for restoring state object after back/forward navigation.

Created test for restoring state object after back/forward navigation.

BUG=673022
Review-Url: https://codereview.chromium.org/2604103002
Cr-Commit-Position: refs/heads/master@{#445858}
Committed: https://chromium.googlesource.com/chromium/src/+/9b5d888f9c2513c1cf033ce7527e38a62b2eb9eb

[kkhorimoto, 2016-12-29 04:03:01]

kkhorimoto@chromium.org changed reviewers:
+ eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2016-12-29 17:19:24]

lgtm I think I leave the same set of comments for the last 2-3 CLs :)
Could you please fix the rest of CLs and ping me, when they ready for review.
This way it will be more efficient...

https://codereview.chromium.org/2604103002/diff/20001/ios/web/navigation/hist...
File ios/web/navigation/history_state_operations_inttest.mm (right):

https://codereview.chromium.org/2604103002/diff/20001/ios/web/navigation/hist...
ios/web/navigation/history_state_operations_inttest.mm:397: std::string
empty_title("");
std::string empty_title;

https://codereview.chromium.org/2604103002/diff/20001/ios/web/navigation/hist...
ios/web/navigation/history_state_operations_inttest.mm:398: GURL empty_url("");
GURL empty_url;

https://codereview.chromium.org/2604103002/diff/20001/ios/web/navigation/hist...
ios/web/navigation/history_state_operations_inttest.mm:413:
web_state()->ExecuteJavaScript(
Please use synchronous API.

https://codereview.chromium.org/2604103002/diff/20001/ios/web/navigation/hist...
ios/web/navigation/history_state_operations_inttest.mm:424:
EXPECT_TRUE(state_object_present);
No need for this line.

[kkhorimoto, 2017-01-24 05:22:54]

https://codereview.chromium.org/2604103002/diff/20001/ios/web/navigation/hist...
File ios/web/navigation/history_state_operations_inttest.mm (right):

https://codereview.chromium.org/2604103002/diff/20001/ios/web/navigation/hist...
ios/web/navigation/history_state_operations_inttest.mm:397: std::string
empty_title("");
On 2016/12/29 17:19:24, Eugene But wrote:
> std::string empty_title;

Done.

https://codereview.chromium.org/2604103002/diff/20001/ios/web/navigation/hist...
ios/web/navigation/history_state_operations_inttest.mm:398: GURL empty_url("");
On 2016/12/29 17:19:24, Eugene But wrote:
> GURL empty_url;

Done.

https://codereview.chromium.org/2604103002/diff/20001/ios/web/navigation/hist...
ios/web/navigation/history_state_operations_inttest.mm:413:
web_state()->ExecuteJavaScript(
On 2016/12/29 17:19:24, Eugene But wrote:
> Please use synchronous API.

Done.

https://codereview.chromium.org/2604103002/diff/20001/ios/web/navigation/hist...
ios/web/navigation/history_state_operations_inttest.mm:424:
EXPECT_TRUE(state_object_present);
On 2016/12/29 17:19:24, Eugene But wrote:
> No need for this line.

Done.

[kkhorimoto, 2017-01-24 23:06:30]

The CQ bit was checked by kkhorimoto@chromium.org

[kkhorimoto, 2017-01-24 23:06:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2604103002/#ps40001
(title: "rebase + eugene's comments")

[commit-bot: I haz the power, 2017-01-24 23:09:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 23:30:38]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485299190461610,
"parent_rev": "a653f8962715401e37ae038f4946e85ab6433d6d", "commit_rev":
"9b5d888f9c2513c1cf033ce7527e38a62b2eb9eb"}

[commit-bot: I haz the power, 2017-01-24 23:31:08]

Description was changed from

==========
Created test for restoring state object after back/forward navigation.

BUG=673022
==========

to

==========
Created test for restoring state object after back/forward navigation.

BUG=673022

Review-Url: https://codereview.chromium.org/2604103002
Cr-Commit-Position: refs/heads/master@{#445858}
Committed:
https://chromium.googlesource.com/chromium/src/+/9b5d888f9c2513c1cf033ce7527e...
==========

[commit-bot: I haz the power, 2017-01-24 23:31:09]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9b5d888f9c2513c1cf033ce7527e...