Created test verifying setting the state object via replaceState()

Created test verifying setting the state object via replaceState()

BUG=673022
Review-Url: https://codereview.chromium.org/2602013002
Cr-Commit-Position: refs/heads/master@{#445838}
Committed: https://chromium.googlesource.com/chromium/src/+/4428bc124888dfc222699a7dc01ea24971c019da

[kkhorimoto, 2016-12-29 04:02:41]

kkhorimoto@chromium.org changed reviewers:
+ eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2016-12-29 17:13:00]

lgtm

https://codereview.chromium.org/2602013002/diff/1/ios/web/navigation/history_...
File ios/web/navigation/history_state_operations_inttest.mm (right):

https://codereview.chromium.org/2602013002/diff/1/ios/web/navigation/history_...
ios/web/navigation/history_state_operations_inttest.mm:8: #import
"base/strings/sys_string_conversions.h"
s/import/include

https://codereview.chromium.org/2602013002/diff/1/ios/web/navigation/history_...
ios/web/navigation/history_state_operations_inttest.mm:316: std::string
empty_title("");
std::string empty_title;

https://codereview.chromium.org/2602013002/diff/1/ios/web/navigation/history_...
ios/web/navigation/history_state_operations_inttest.mm:317: GURL empty_url("");
GURL empty_url;

https://codereview.chromium.org/2602013002/diff/1/ios/web/navigation/history_...
ios/web/navigation/history_state_operations_inttest.mm:327:
base::SysNSStringToUTF8(item->GetSerializedStateObject());
Is there a way to avoid using implementation details?

https://codereview.chromium.org/2602013002/diff/1/ios/web/navigation/history_...
ios/web/navigation/history_state_operations_inttest.mm:328: state_updated =
item_state == serialized_state;
return item_state == serialized_state;

https://codereview.chromium.org/2602013002/diff/1/ios/web/navigation/history_...
ios/web/navigation/history_state_operations_inttest.mm:331:
EXPECT_TRUE(state_updated);
There is no need for this check.

[kkhorimoto, 2017-01-24 04:57:15]

https://codereview.chromium.org/2602013002/diff/1/ios/web/navigation/history_...
File ios/web/navigation/history_state_operations_inttest.mm (right):

https://codereview.chromium.org/2602013002/diff/1/ios/web/navigation/history_...
ios/web/navigation/history_state_operations_inttest.mm:8: #import
"base/strings/sys_string_conversions.h"
On 2016/12/29 17:12:59, Eugene But wrote:
> s/import/include

Done.

https://codereview.chromium.org/2602013002/diff/1/ios/web/navigation/history_...
ios/web/navigation/history_state_operations_inttest.mm:316: std::string
empty_title("");
On 2016/12/29 17:12:59, Eugene But wrote:
> std::string empty_title;

Done.

https://codereview.chromium.org/2602013002/diff/1/ios/web/navigation/history_...
ios/web/navigation/history_state_operations_inttest.mm:317: GURL empty_url("");
On 2016/12/29 17:12:59, Eugene But wrote:
> GURL empty_url;

Done.

https://codereview.chromium.org/2602013002/diff/1/ios/web/navigation/history_...
ios/web/navigation/history_state_operations_inttest.mm:327:
base::SysNSStringToUTF8(item->GetSerializedStateObject());
On 2016/12/29 17:12:59, Eugene But wrote:
> Is there a way to avoid using implementation details?

Not really.  NavigationEntry doesn't expose the state object, so it's better for
us to also keep it contained to the implementation file.  I've also added a
check for the actual state object returned by JavaScript, but it'd be better to
check the NavigationItem state as well.

https://codereview.chromium.org/2602013002/diff/1/ios/web/navigation/history_...
ios/web/navigation/history_state_operations_inttest.mm:328: state_updated =
item_state == serialized_state;
On 2016/12/29 17:13:00, Eugene But wrote:
> return item_state == serialized_state;

Done.

https://codereview.chromium.org/2602013002/diff/1/ios/web/navigation/history_...
ios/web/navigation/history_state_operations_inttest.mm:331:
EXPECT_TRUE(state_updated);
On 2016/12/29 17:13:00, Eugene But wrote:
> There is no need for this check.

Done.

[kkhorimoto, 2017-01-24 22:08:53]

The CQ bit was checked by kkhorimoto@chromium.org

[kkhorimoto, 2017-01-24 22:08:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2602013002/#ps40001
(title: "decomposed js state getter")

[commit-bot: I haz the power, 2017-01-24 22:09:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 22:21:17]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485295733425440,
"parent_rev": "48120c66427ca6cb54f11aa2c0c09e5b739a9e92", "commit_rev":
"4428bc124888dfc222699a7dc01ea24971c019da"}

[commit-bot: I haz the power, 2017-01-24 22:21:55]

Description was changed from

==========
Created test verifying setting the state object via replaceState()

BUG=673022
==========

to

==========
Created test verifying setting the state object via replaceState()

BUG=673022

Review-Url: https://codereview.chromium.org/2602013002
Cr-Commit-Position: refs/heads/master@{#445838}
Committed:
https://chromium.googlesource.com/chromium/src/+/4428bc124888dfc222699a7dc01e...
==========

[commit-bot: I haz the power, 2017-01-24 22:21:56]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4428bc124888dfc222699a7dc01e...