ui/file_manager/file_manager/foreground/js/metadata/external_metadata_provider.js - Issue 2607453002: Files.app: Compile file_manager/foreground/js/metadata in v2 syntax.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/foreground/js/metadata/external_metadata_provider.js

Issue 2607453002: Files.app: Compile file_manager/foreground/js/metadata in v2 syntax. (Closed)

Patch Set: Re-rebase (PS4 had unrelated changes.) Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/file_manager/file_manager/foreground/js/metadata/exif_parser.js ('k') | ui/file_manager/file_manager/foreground/js/metadata/external_metadata_provider_unittest.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/file_manager/file_manager/foreground/js/metadata/external_metadata_provider.js

diff --git a/ui/file_manager/file_manager/foreground/js/metadata/external_metadata_provider.js b/ui/file_manager/file_manager/foreground/js/metadata/external_metadata_provider.js

index cd3cbbc8187a6467a1f4a16aad236d23fd5f7e10..4cf2ae29adaabfae1e607595a20f197423ada506 100644

--- a/ui/file_manager/file_manager/foreground/js/metadata/external_metadata_provider.js

+++ b/ui/file_manager/file_manager/foreground/js/metadata/external_metadata_provider.js

@@ -50,7 +50,7 @@ ExternalMetadataProvider.prototype.get = function(requests) {

var entries = requests.map(function(request) {

return request.entry;

});

- var nameMap = [];

+ var nameMap = {};

for (var i = 0; i < requests.length; i++) {

for (var j = 0; j < requests[i].names.length; j++) {

nameMap[requests[i].names[j]] = true;