third_party/closure_compiler/compile2.py - Issue 2607453002: Files.app: Compile file_manager/foreground/js/metadata in v2 syntax.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/closure_compiler/compile2.py

Issue 2607453002: Files.app: Compile file_manager/foreground/js/metadata in v2 syntax. (Closed)

Patch Set: Re-rebase (PS4 had unrelated changes.) Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/closure_compiler/compile2.py

diff --git a/third_party/closure_compiler/compile2.py b/third_party/closure_compiler/compile2.py

index dfd22cfe26700adbec40eaeb000337cc5a474319..9fe803905de19c98e13cd5da4c280089f278e3b5 100755

--- a/third_party/closure_compiler/compile2.py

+++ b/third_party/closure_compiler/compile2.py

@@ -206,7 +206,7 @@ class Checker(object):

(found_errors, stderr) A boolean indicating whether errors were found and

the raw Closure compiler stderr (as a string).

"""

- is_extern = lambda f: 'extern' in f

+ is_extern = lambda f: 'externs' in f

externs_and_deps = [self._POLYMER_EXTERNS]

if custom_sources:

« no previous file with comments | « no previous file | ui/file_manager/audio_player/js/audio_player_scripts.js » ('j') | no next file with comments »