Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2607113003: Implement 5 ARIA 1.1 roles: cell, feed, figure, table, term (Closed)

Created:
3 years, 11 months ago by dmazzoni
Modified:
3 years, 11 months ago
Reviewers:
aboxhall
CC:
chromium-reviews, extensions-reviews_chromium.org, aboxhall, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, dglazkov+blink, yuzo+watch_chromium.org, haraken, nektarios, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, kinuko+watch, blink-reviews-api_chromium.org, dmazzoni
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement 5 ARIA 1.1 roles: cell, feed, figure, table, term These 5 roles are all defined in the ARIA 1.1 editor's draft. All 5 are quite trivial because we either already supported them as a native HTML role, or we just pass them through to assistive technology without affecting any semantics. The spec is defined here: https://rawgit.com/w3c/aria/master/aria/aria.html The test expectations were checked against the latest draft of the Core Accessibility API Mappings: http://w3c.github.io/aria/core-aam/core-aam.html BUG=644766 Review-Url: https://codereview.chromium.org/2607113003 Cr-Commit-Position: refs/heads/master@{#442199} Committed: https://chromium.googlesource.com/chromium/src/+/df5ab817cb455c368ef3aeb147b2908d8247922b

Patch Set 1 #

Patch Set 2 : Update test expectations #

Patch Set 3 : Fix role mappings and expectations #

Patch Set 4 : Fix blink to Chrome enum mapping #

Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -12 lines) Patch
M chrome/common/extensions/api/automation.idl View 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_cocoa.mm View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win.cc View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 4 chunks +20 lines, -0 lines 0 comments Download
M content/renderer/accessibility/blink_ax_enum_conversion.cc View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-cell.html View 1 chunk +20 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-cell-expected-win.txt View 1 1 chunk +12 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-feed.html View 1 chunk +15 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-feed-expected-mac.txt View 1 1 chunk +6 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-feed-expected-win.txt View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-figure.html View 1 chunk +10 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-figure-expected-mac.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-figure-expected-win.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-table.html View 1 chunk +19 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-table-expected-mac.txt View 1 1 chunk +12 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-table-expected-win.txt View 1 1 chunk +12 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-term.html View 1 chunk +17 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-term-expected-mac.txt View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-term-expected-win.txt View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-nameSources-img-figure-expected.txt View 1 2 5 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObject.h View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObject.cpp View 5 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/AssertMatchingEnums.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebAXEnums.h View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/accessibility/ax_enums.idl View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_mac.mm View 1 2 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (21 generated)
dmazzoni
3 years, 11 months ago (2016-12-30 23:23:11 UTC) #13
aboxhall
lgtm As you say, all very straightforward!
3 years, 11 months ago (2017-01-05 22:57:33 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2607113003/60001
3 years, 11 months ago (2017-01-09 04:02:00 UTC) #22
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 06:05:08 UTC) #25
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/df5ab817cb455c368ef3aeb147b2...

Powered by Google App Engine
This is Rietveld 408576698