content/browser/accessibility/browser_accessibility_cocoa.mm - Issue 2607113003: Implement 5 ARIA 1.1 roles: cell, feed, figure, table, term

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_cocoa.mm

Issue 2607113003: Implement 5 ARIA 1.1 roles: cell, feed, figure, table, term (Closed)

Patch Set: Fix blink to Chrome enum mapping Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/accessibility/browser_accessibility_cocoa.mm

diff --git a/content/browser/accessibility/browser_accessibility_cocoa.mm b/content/browser/accessibility/browser_accessibility_cocoa.mm

index 041793a5364bd7ca88ea7b57a2a0ef5939802a3c..896f4add4544ac5398bc4e8bac31e2632c226797 100644

--- a/content/browser/accessibility/browser_accessibility_cocoa.mm

+++ b/content/browser/accessibility/browser_accessibility_cocoa.mm

@@ -1470,6 +1470,9 @@ NSString* const NSAccessibilityRequiredAttribute = @"AXRequired";

case ui::AX_ROLE_SWITCH:

return base::SysUTF16ToNSString(content_client->GetLocalizedString(

IDS_AX_ROLE_SWITCH));

+ case ui::AX_ROLE_TERM:

+ return base::SysUTF16ToNSString(content_client->GetLocalizedString(

+ IDS_AX_ROLE_DESCRIPTION_TERM));

case ui::AX_ROLE_TOGGLE_BUTTON:

return base::SysUTF16ToNSString(content_client->GetLocalizedString(

IDS_AX_ROLE_TOGGLE_BUTTON));