third_party/WebKit/Source/modules/accessibility/AXObject.cpp - Issue 2607113003: Implement 5 ARIA 1.1 roles: cell, feed, figure, table, term

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXObject.cpp

Issue 2607113003: Implement 5 ARIA 1.1 roles: cell, feed, figure, table, term (Closed)

Patch Set: Fix blink to Chrome enum mapping Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/accessibility/AXObject.h ('k') | third_party/WebKit/Source/web/AssertMatchingEnums.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/accessibility/AXObject.cpp

diff --git a/third_party/WebKit/Source/modules/accessibility/AXObject.cpp b/third_party/WebKit/Source/modules/accessibility/AXObject.cpp

index bc0a87f1f01a031efaa690be400c538633150678..bfdb7d7c96b7536cac139536b928d58b0ffb4ac6 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXObject.cpp

+++ b/third_party/WebKit/Source/modules/accessibility/AXObject.cpp

@@ -68,6 +68,7 @@ const RoleEntry roles[] = {{"alert", AlertRole},

{"article", ArticleRole},

{"banner", BannerRole},

{"button", ButtonRole},

+ {"cell", CellRole},

{"checkbox", CheckBoxRole},

{"columnheader", ColumnHeaderRole},

{"combobox", ComboBoxRole},

@@ -77,6 +78,8 @@ const RoleEntry roles[] = {{"alert", AlertRole},

{"dialog", DialogRole},

{"directory", DirectoryRole},

{"document", DocumentRole},

+ {"feed", FeedRole},

+ {"figure", FigureRole},

{"form", FormRole},

{"grid", GridRole},

{"gridcell", CellRole},

@@ -116,8 +119,10 @@ const RoleEntry roles[] = {{"alert", AlertRole},

{"status", StatusRole},

{"switch", SwitchRole},

{"tab", TabRole},

+ {"table", TableRole},

{"tablist", TabListRole},

{"tabpanel", TabPanelRole},

+ {"term", TermRole},

{"text", StaticTextRole},

{"textbox", TextFieldRole},

{"timer", TimerRole},

@@ -169,6 +174,7 @@ const InternalRoleEntry internalRoles[] = {

{DivRole, "Div"},

{DocumentRole, "Document"},

{EmbeddedObjectRole, "EmbeddedObject"},

+ {FeedRole, "feed"},

{FigcaptionRole, "Figcaption"},

{FigureRole, "Figure"},

{FooterRole, "Footer"},

@@ -244,6 +250,7 @@ const InternalRoleEntry internalRoles[] = {

{TabRole, "Tab"},

{TableHeaderContainerRole, "TableHeaderContainer"},

{TableRole, "Table"},

+ {TermRole, "Term"},

{TextFieldRole, "TextField"},

{TimeRole, "Time"},

{TimerRole, "Timer"},