Replace MockImageResourceClient with MockImageResourceObserver

Replace MockImageResourceClient with MockImageResourceObserver

To distinguish ImageResource and ImageResourceContent in ImageResourceTest
more clearly and make tests more ImageResourceContent-centric, this CL
- Replaces MockImageResourceClient
  (that was both a ResourceClient and an ImageResourceObserver) with
  MockImageResourceObserver (that is not a ResourceClient),
- Replaces checks on notifyFinished() with checks on imageNotifyFinished(),
- Replaces checks on encodedSize() (that are used to check that expected
  image data is loaded) with checks on image width.

BUG=667641
Review-Url: https://codereview.chromium.org/2607023002
Cr-Commit-Position: refs/heads/master@{#445658}
Committed: https://chromium.googlesource.com/chromium/src/+/5488d0abc4a664aefb1e65f883bacea353523dba

[hiroshige, 2016-12-28 23:21:35]

Description was changed from

==========
Replace MockImageResourceClient with MockImageResourceObserver

BUG=
==========

to

==========
Replace MockImageResourceClient with MockImageResourceObserver

To distinguish ImageResource and ImageResourceContent in ImageResourceTest
more clearly and make tests more ImageResourceContent-centric, this CL
- Replaces MockImageResourceClient
  (that was both a ResourceClient and an ImageResourceObserver) with
  MockImageResourceObserver (that is not a ResourceClient),
- Replaces checks on notifyFinished() with checks on imageNotifyFinished(),
- Replaces checks on encodedSize() (that are used to check that expected
  image data is loaded) with checks on image width.

BUG=667641
==========

[hiroshige, 2016-12-28 23:21:35]

hiroshige@chromium.org changed reviewers:
+ japhet@chromium.org, yhirano@chromium.org

[hiroshige, 2016-12-28 23:25:21]

PTAL.

Addressing the comment
https://codereview.chromium.org/2527353002/diff/180001/third_party/WebKit/Sou....

[hiroshige, 2016-12-28 23:25:27]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 23:25:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-29 01:13:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-29 01:13:36]

Dry run: This issue passed the CQ dry run.

[yhirano, 2017-01-06 05:32:39]

lgtm

https://codereview.chromium.org/2607023002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp
(right):

https://codereview.chromium.org/2607023002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp:92: const
int kJpegImageWidth = 1;
constexpr

ditto below

https://codereview.chromium.org/2607023002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp:366: //
should
Reflow needed?

https://codereview.chromium.org/2607023002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/core/loader/resource/MockImageResourceObserver.cpp
(right):

https://codereview.chromium.org/2607023002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/resource/MockImageResourceObserver.cpp:1:
// Copyright 2016 The Chromium Authors. All rights reserved.
ditto

https://codereview.chromium.org/2607023002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/resource/MockImageResourceObserver.h
(right):

https://codereview.chromium.org/2607023002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/resource/MockImageResourceObserver.h:1: //
Copyright 2016 The Chromium Authors. All rights reserved.
2017?

https://codereview.chromium.org/2607023002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/resource/MockImageResourceObserver.h:23:
void removeAsObserver();
I'd prefer stopObserving or something, but it's optional.

[hiroshige, 2017-01-06 20:04:28]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[hiroshige, 2017-01-06 20:04:33]

https://codereview.chromium.org/2607023002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp
(right):

https://codereview.chromium.org/2607023002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp:92: const
int kJpegImageWidth = 1;
On 2017/01/06 05:32:38, yhirano wrote:
> constexpr
> 
> ditto below

Done.

https://codereview.chromium.org/2607023002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp:366: //
should
On 2017/01/06 05:32:38, yhirano wrote:
> Reflow needed?

Done.

https://codereview.chromium.org/2607023002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/core/loader/resource/MockImageResourceObserver.cpp
(right):

https://codereview.chromium.org/2607023002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/resource/MockImageResourceObserver.cpp:1:
// Copyright 2016 The Chromium Authors. All rights reserved.
On 2017/01/06 05:32:38, yhirano wrote:
> ditto

ditto.

https://codereview.chromium.org/2607023002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/resource/MockImageResourceObserver.h
(right):

https://codereview.chromium.org/2607023002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/resource/MockImageResourceObserver.h:1: //
Copyright 2016 The Chromium Authors. All rights reserved.
On 2017/01/06 05:32:38, yhirano wrote:
> 2017?

I thought this is a kind of file renaming from MockImageResourceClient.h (the
diffs are large though), so leaving the copyright header.
(I'm not so sure though)

https://codereview.chromium.org/2607023002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/resource/MockImageResourceObserver.h:23:
void removeAsObserver();
On 2017/01/06 05:32:39, yhirano wrote:
> I'd prefer stopObserving or something, but it's optional.

I'll keep this to keep correspondence with removeObserver().

[commit-bot: I haz the power, 2017-01-06 20:04:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 23:11:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 23:11:34]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2017-01-18 19:59:35]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 20:00:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 22:02:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 22:02:58]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2017-01-19 21:10:41]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 21:11:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 22:41:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 22:41:40]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2017-01-20 19:14:40]

friendly ping; Nate, could you take a look at core/BUILD.gn change?

[hiroshige, 2017-01-20 20:57:11]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 20:57:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 22:33:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 22:33:46]

Dry run: This issue passed the CQ dry run.

[kouhei (in TOK), 2017-01-24 00:30:56]

kouhei@chromium.org changed reviewers:
+ kouhei@chromium.org

[kouhei (in TOK), 2017-01-24 00:30:57]

core lgtm

[hiroshige, 2017-01-24 01:54:19]

The CQ bit was checked by hiroshige@chromium.org

[hiroshige, 2017-01-24 01:54:20]

The patchset sent to the CQ was uploaded after l-g-t-m from yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/2607023002/#ps100001
(title: "Rebase")

[commit-bot: I haz the power, 2017-01-24 01:55:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 05:36:27]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1485222859640810,
"parent_rev": "d280ab1a052245d5bcacf63a4478fc3c0f085899", "commit_rev":
"5488d0abc4a664aefb1e65f883bacea353523dba"}

[commit-bot: I haz the power, 2017-01-24 05:37:13]

Description was changed from

==========
Replace MockImageResourceClient with MockImageResourceObserver

To distinguish ImageResource and ImageResourceContent in ImageResourceTest
more clearly and make tests more ImageResourceContent-centric, this CL
- Replaces MockImageResourceClient
  (that was both a ResourceClient and an ImageResourceObserver) with
  MockImageResourceObserver (that is not a ResourceClient),
- Replaces checks on notifyFinished() with checks on imageNotifyFinished(),
- Replaces checks on encodedSize() (that are used to check that expected
  image data is loaded) with checks on image width.

BUG=667641
==========

to

==========
Replace MockImageResourceClient with MockImageResourceObserver

To distinguish ImageResource and ImageResourceContent in ImageResourceTest
more clearly and make tests more ImageResourceContent-centric, this CL
- Replaces MockImageResourceClient
  (that was both a ResourceClient and an ImageResourceObserver) with
  MockImageResourceObserver (that is not a ResourceClient),
- Replaces checks on notifyFinished() with checks on imageNotifyFinished(),
- Replaces checks on encodedSize() (that are used to check that expected
  image data is loaded) with checks on image width.

BUG=667641

Review-Url: https://codereview.chromium.org/2607023002
Cr-Commit-Position: refs/heads/master@{#445658}
Committed:
https://chromium.googlesource.com/chromium/src/+/5488d0abc4a664aefb1e65f883ba...
==========

[commit-bot: I haz the power, 2017-01-24 05:37:14]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/5488d0abc4a664aefb1e65f883ba...